[QueryBuilder] Implement get_creation_statistics for SQLite backend
#6763
+21
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabbull
force-pushed
the
feature/sqlite_creation_stat
branch
from
14e5328 to
79e747d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6763 +/- ##
==========================================
+ Coverage 78.15% 78.15% +0.01%
==========================================
Files 564 564
Lines 42643 42654 +11
==========================================
+ Hits 33322 33332 +10
- Misses 9321 9322 +1 ☔ View full report in Codecov by Sentry. |
GeigerJ2
changed the title
get_creation_statastics for SQLite backendget_creation_statistics for SQLite backend
GeigerJ2
previously approved these changes
Feb 20, 2025
GeigerJ2
reviewed
Feb 20, 2025
|
Hi @GeigerJ2, this PR is ready for another review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves backend parity between two database backends by implementing
get_creation_statisticsfor the SQLite backend. It achieves this by using an alternative method to implementdate_trunc, which is available in PostgreSQL but not in SQLite.Closes #6747.