Tests: omit needless requires_rmq for tests that don't need RabbitMQ
#7076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7076 +/- ##
==========================================
+ Coverage 77.59% 77.60% +0.01%
==========================================
Files 566 566
Lines 43498 43498
==========================================
+ Hits 33750 33754 +4
+ Misses 9748 9744 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GeigerJ2
approved these changes
Nov 10, 2025
Contributor
GeigerJ2
left a comment
GeigerJ2
left a comment
There was a problem hiding this comment.
Great, thanks a lot, @danielhollas!
danielhollas
added a commit
to danielhollas/aiida-core
that referenced
this pull request
Nov 16, 2025
… RabbitMQ (aiidateam#7076)" This reverts commit 586f372.
danielhollas
added a commit
to danielhollas/aiida-core
that referenced
this pull request
Nov 17, 2025
… RabbitMQ (aiidateam#7076)" This reverts commit 586f372.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that there are a lot of tests marked with
requires_rmqpytest marker even though they run perfectly fine without RabbitMQ. That probably comes from a time before theprestocommand and before there was an option to have a profile without a broker.Split from #7074
Test plan
Make sure that the
tests-prestoCI job passes.