Adding the verdi computer goto command
#7124
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While one could simply do `ssh loginname` if the transport is ssh and the .ssh/config has been setup correctly, this might not always be the case, and this allows testing the `goto` functionality even when no calculations have been submitted yet, or when the last calculation submitted to the given computer was a long time ago and it would take a lot of time to find it (with also the possibility that the remote folder was deleted).
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7124 +/- ##
==========================================
+ Coverage 79.58% 79.60% +0.02%
==========================================
Files 566 566
Lines 43520 43537 +17
==========================================
+ Hits 34631 34653 +22
+ Misses 8889 8884 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
khsrali
approved these changes
Dec 5, 2025
Contributor
khsrali
left a comment
khsrali
left a comment
There was a problem hiding this comment.
Thanks @giovannipizzi, all good! I'd also adopt the type signature (see the comment)
| return self._safe_open_interval | ||
|
|
||
| def _gotocomputer_string(self, remotedir): | ||
| def _gotocomputer_string(self, remotedir=None): |
Contributor
There was a problem hiding this comment.
Suggested change
| def _gotocomputer_string(self, remotedir=None): | |
| def _gotocomputer_string(self, remotedir: Optional[TransportPath] = None): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While one could simply do
ssh loginnameif the transport is ssh and the .ssh/config has been setup correctly, this might not always be the case, and this allows testing thegotofunctionality even when no calculations have been submitted yet, or when the last calculation submitted to the given computer was a long time ago and it would take a lot of time to find it (with also the possibility that the remote folder was deleted).Note: I'm making the remotedir parameter optional. This is in principle backward-incompatible, in a sense (meaning that the new
computer gotocommand will not work for external plugins that require this parameter. The rest will stil work - so it's not a real backward-incompatibility, only new functionality will not work and can be easily fixed).If this is a problem, we can probably pass
remotedir='.'which works at least withcore.local, but I'm not sure if this will work all the times.