Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Other tools support in wannier90 packge for this plugin. #100

Open
hongyi-zhao opened this issue Apr 22, 2020 · 5 comments
Open

Other tools support in wannier90 packge for this plugin. #100

hongyi-zhao opened this issue Apr 22, 2020 · 5 comments

Comments

@hongyi-zhao
Copy link

Hi,

I noted that there are several tools included in wannier90 packge, say the following:

$ ls *.x
postw90.x  w90chk2chk.x  w90spn2spn.x  wannier90.x

But it seems this plugin only support the wannier90.x of them. Any hints?

Regards

@greschd
Copy link
Member

greschd commented Apr 22, 2020

That's correct, these are not currently supported by aiida-wannier90 - I don't know if there are any plans to add support, but if you're willing to implement this we can certainly help you with the design questions.

@giovannipizzi would know if there is already some ongoing work on this.

@hongyi-zhao
Copy link
Author

hongyi-zhao commented Apr 22, 2020 via email

@greschd
Copy link
Member

greschd commented Apr 22, 2020

I think this is a design choice of having more but simple tools, following (roughly) the UNIX philosophy of "doing one thing well".

From the point of view of AiiDA it doesn't make that much of a difference whether we have many simple calculation plugins, or a single more complex one.

I can't comment on whether the "separate tools" or "monolith" approach would be better in this specific case - both have their advantages and drawbacks.

@giovannipizzi
Copy link
Member

There is plan to support at least postw90.x, this might happen relatively soon but we have no official timeline yet. Mentioning also @normarivano and @qiaojunfeng who might end up implementing them (but we cannot guarantee anything at the moment)

@qiaojunfeng
Copy link
Collaborator

On our wishlist :), but no concrete plan for the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants