Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type annotation incomplete for visx/geo fitExtent/fitSize #1856

Open
aendra-rininsland opened this issue Jun 25, 2024 · 0 comments
Open

Type annotation incomplete for visx/geo fitExtent/fitSize #1856

aendra-rininsland opened this issue Jun 25, 2024 · 0 comments

Comments

@aendra-rininsland
Copy link

aendra-rininsland commented Jun 25, 2024

These lines for the fitExtent and fitSize props have ExtendedFeatureCollection commented out for some reason, which is preventing me from passing a FeatureCollection to my Projection component in TypeScript.

https://github.com/airbnb/visx/blob/master/packages/visx-geo/src/projections/Projection.tsx#L71
https://github.com/airbnb/visx/blob/master/packages/visx-geo/src/projections/Projection.tsx#L76

AFAICT it works fine to pass a FeatureCollection to; I'd submit a PR fixing those lines but given they're commented out was thinking there might be another reason why that I'm missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant