Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposes to add in the wild to hosted visx site #1803

Closed
wants to merge 2 commits into from
Closed

Proposes to add in the wild to hosted visx site #1803

wants to merge 2 commits into from

Conversation

mcioffi
Copy link
Contributor

@mcioffi mcioffi commented Feb 22, 2024 •
edited
Loading

🚀 Enhancements

  • PR proposes to expose "in the wild" not just in README.md, but also on the hosted site at airbnb.io/visx/
  • Code changes included creates new nav tab nearly identical to airbnb.io/visx/gallery
  • Screenshots to external site assets maintained identically to Docusaurus here and also here from 11ty folks — as Docusaurus is actively maintained by meta/facebook, should be safe to use these services
  • Any new sites can be added in the list in the small data file under packages/visx-demo/src/showcase/sites.js

NOTE: entire list of "in the wild" here is not 100% comprehensive, and any footnotes by visx maintainers should be added to this new page since this is maintained by airbnb

Screenshot 2024-02-22 at 17-54-24 visx in the wild

williaster
williaster reviewed Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mcioffi , thanks for all of the work here and for this interesting direction for in the wild. After discussing with the maintainers we decided we don't want to take on the extra maintenance burden of the slorber-api-screenshot.netlify.app API – despite other projects like react using them.

so at this time we won't be merging this. again, thank you for the effort and idea 🙏

@williaster williaster closed this Mar 4, 2024
@mcioffi
Copy link
Contributor Author

mcioffi commented Mar 11, 2024

@williaster makes sense 👍. Perhaps you and the visx maintainers might be open to an airbnb self-hosted similar service in the future, as 11ty (maintains https://v1.screenshot.11ty.dev/) and docusarus (which maintains slorber-api-screenshot.netlify.app)? I believe the latter is actually a carbon copy of the first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williaster williaster williaster left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcioffi @williaster