Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes #17

Merged
merged 6 commits into from
Sep 11, 2024
Merged

Bug fixes #17

merged 6 commits into from
Sep 11, 2024

Conversation

sstroemer
Copy link
Member

This fixes an error when adding plain variables to a custom objective (instead of expressions), and may be a partial fit for #12 .

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 6 lines in your changes missing coverage. Please review.

Project coverage is 52.42%. Comparing base (e2006d4) to head (2d38647).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/IESopt.jl 72.72% 3 Missing ⚠️
src/utils/logging.jl 80.00% 3 Missing ⚠️
@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
+ Coverage   52.30%   52.42%   +0.12%     
==========================================
  Files          99       99              
  Lines        3776     3792      +16     
==========================================
+ Hits         1975     1988      +13     
- Misses       1801     1804       +3     
Files with missing lines Coverage Δ
src/parser.jl 80.47% <100.00%> (ø)
src/IESopt.jl 54.48% <72.72%> (+0.29%) ⬆️
src/utils/logging.jl 82.60% <80.00%> (-1.03%) ⬇️

@sstroemer sstroemer merged commit ee13b43 into main Sep 11, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant