disable jekyll for gh-pages #5376
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5376 +/- ##
=======================================
Coverage 87.50% 87.50%
=======================================
Files 583 583
Lines 46100 46100
Branches 6990 6990
=======================================
Hits 40342 40342
Misses 5758 5758
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tool/release-api-docs.sh
Outdated
| @@ -32,6 +32,9 @@ mv ../doc/* . | |||
| git reset origin/gh-pages | |||
| git add . | |||
|
|
|||
| echo "see https://github.com/ajaxorg/ace/issues/5375" > .nojekyll | |||
| git add .nojekyll -f | |||
There was a problem hiding this comment.
Do we need to create this .nojekyll file (which then completely bypasses Jekyll processing) in this script or can we just create it outside of it and commit it to the master branch and then it's always there?
There was a problem hiding this comment.
We can create the file outside of it too, i've used the script to not have too many files in repository root, but maybe that would be better than having more complex script. Do you think we should just commit it to the master?
There was a problem hiding this comment.
Yeah i like it more because it's more explicit. Like opening the repo we imediattely know that we don't use any of the Jekyll features.
fixes #5375
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.