Broken Release 3.3.0.4

[kirchnerf]

Something seems to have gone wrong when building release 3.3.0.4. For example, the FundingPlugin.inc.php contained in the tarball is not identical to the version of tag 3.3.0.4. Also #46 appears again.

[ajnyga]

ok thanks, I will check what it is

[ajnyga]

Does this work for you https://github.com/ajnyga/funding/releases/tag/3.3.0.5

[kirchnerf]

Unfortunately not, same issue as described in #46

[ajnyga]

Oh, which of the files in the release are you testing. I noticed that for some reason two of the files do contain an old version (not sure yet how that happens) but the manually added one should be ok? But I will recheck with all three apps later today. Sorry for the trouble!

[almereyda]

Coming from #60 I can confirm that the branch stable-3_3_0 contains different commits than the released tags.

---

• https://github.com/ajnyga/funding/releases/tag/3.3.0.5

tags

• 7c0a6e7, which is the 3.4.0.4 commit.

---

• https://github.com/ajnyga/funding/releases/tag/3.3.0.4

tags

• cdbccba, which appears to come from master and is also contained in 3.4.0.4.

---

The branch stable-3_3_0 has these corresponding commits:

• c173d37
  • 3.3.0.4
• 06e7366
  • 3.3.0.5

[almereyda]

Pinging @ajnyga

This is a serious regression with how the previous 3.3.0.x releases were cut, which breaks them on OJS 3.3 instances.

May I propose to retract the earlier ones, incl. their tags, and to push them anew?

[ajnyga]

Hi,

This was probably caused by a mistake I made while doing the releases here and got I bit confused because I tested this first just with OJS.

I have a new release here I did not add to the plugin gallery yet, can you confirm that this works for you before I do.

https://github.com/ajnyga/funding/releases/tag/3.3.0.6

Thank you for the patience with this one.

[almereyda]

Don't worry (: Let's get everything ready before the Crossref OJS workshop on March 13.

• https://mastodon.online/@crossref/114031379389572767

I will be able to look into this next week.

[ajnyga]

thanks, good to know that is coming.

[almereyda]

Sorry for the delay.

This works as expected:

# git remote -v
origin  https://github.com/ajnyga/funding.git (fetch)
origin  https://github.com/ajnyga/funding.git (push)
# git fetch
remote: Enumerating objects: 4, done.
remote: Counting objects: 100% (4/4), done.
remote: Total 4 (delta 3), reused 4 (delta 3), pack-reused 0 (from 0)
Unpacking objects: 100% (4/4), 396 bytes | 198.00 KiB/s, done.
From https://github.com/ajnyga/funding
   06e7366..a4b775b  stable-3_3_0 -> origin/stable-3_3_0
 * [new tag]         3.3.0.6      -> 3.3.0.6
# git log origin/stable-3_3_0
commit a4b775b35c38338acc4c35b7d19f91c548a8a73a (tag: 3.3.0.6, origin/stable-3_3_0)
Author: Antti-Jussi Nygård <ajnyga@gmail.com>
Date:   Sat Feb 22 18:22:24 2025 +0200

    Fix template call in OMP 3.3

commit 06e736622540250da489d387d69314d8a671f7d6 (HEAD -> stable-3_3_0)
Author: Antti-Jussi Nygård <ajnyga@gmail.com>
Date:   Fri Jan 3 11:22:55 2025 +0200

    bump version

# git switch -d 3.3.0.6
HEAD is now at a4b775b Fix template call in OMP 3.3
# git log
commit a4b775b35c38338acc4c35b7d19f91c548a8a73a (HEAD, tag: 3.3.0.6, upstream/stable-3_3_0)
Author: Antti-Jussi Nygård <ajnyga@gmail.com>
Date:   Sat Feb 22 18:22:24 2025 +0200

    Fix template call in OMP 3.3

commit 06e736622540250da489d387d69314d8a671f7d6 (stable-3_3_0)
Author: Antti-Jussi Nygård <ajnyga@gmail.com>
Date:   Fri Jan 3 11:22:55 2025 +0200

    bump version

Though I'm still seeing the broken releases and tags with the affected commits:

• https://github.com/ajnyga/funding/releases
• https://github.com/ajnyga/funding/tags

Would it seem useful to retract and delete them?

There are also more Metadata health check webinars - Crossref coming up, also one on Apr. 1st by CRAFT-OA.