From 018a0e3ed39efd0e1c2e8a927edcf5464271eddb Mon Sep 17 00:00:00 2001 From: Andrew Oberstar Date: Sat, 30 Dec 2023 15:36:48 -0600 Subject: [PATCH] Register tasks earlier @jnehlmeier noticed that it can be difficult to create other settings plugins that build off the tag/push tasks that reckon registers due to them being registered after projectLoaded. Since these are only added to the root project, its a trivial tweak to just register directly on rootProject and avoid the extra ordering confusion for downstream authors. Fixes #200 --- .../org/ajoberstar/reckon/gradle/ReckonSettingsPlugin.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/reckon-gradle/src/main/java/org/ajoberstar/reckon/gradle/ReckonSettingsPlugin.java b/reckon-gradle/src/main/java/org/ajoberstar/reckon/gradle/ReckonSettingsPlugin.java index 1cd4e9a..3156961 100644 --- a/reckon-gradle/src/main/java/org/ajoberstar/reckon/gradle/ReckonSettingsPlugin.java +++ b/reckon-gradle/src/main/java/org/ajoberstar/reckon/gradle/ReckonSettingsPlugin.java @@ -36,9 +36,9 @@ public void apply(Settings settings) { prj.setVersion(sharedVersion); }); - settings.getGradle().projectsLoaded(gradle -> { - var tag = createTagTask(settings.getGradle().getRootProject(), extension); - var push = createPushTask(settings.getGradle().getRootProject(), extension); + settings.getGradle().rootProject(rootProject -> { + var tag = createTagTask(rootProject, extension); + var push = createPushTask(rootProject, extension); push.configure(t -> t.dependsOn(tag)); }); }