New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should this line be "del matched_treated['treated_index']"? #93

Open

ZJianL opened this issue Oct 11, 2023 · 2 comments

ZJianL commented Oct 11, 2023

https://github.com/akelleh/causality/blob/aa458538224ec162b751c1e225b1ff02cb474191/causality/estimation/parametric.py#L201C34-L201C34
In the get_treated_matches function of the PropensityScoringModel class, after join, did you mean to delete the treated_index instead of control_index? Because I think what we need in the matched_treated is the control_index which has been deleted in this version.

The text was updated successfully, but these errors were encountered:

cjqjyy commented Nov 11, 2023

I think so too.

cjqjyy commented Nov 11, 2023

https://github.com/akelleh/causality/blob/aa458538224ec162b751c1e225b1ff02cb474191/causality/estimation/parametric.py#L201C34-L201C34
del matched_treated['control_index'] should be del matched_treated['treated_index']

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment