From 3930ebd10d334132673ffe1f69aef6f807c3038d Mon Sep 17 00:00:00 2001 From: "Mazzella, Jesse D. (ARC-TI)[KBR Wyle Services, LLC]" Date: Mon, 14 Oct 2024 16:27:28 -0700 Subject: [PATCH 1/2] refactor: rename `Indefinite` to `Unlimited` --- src/providers/fault-mgmt-providers/fault-action-provider.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/providers/fault-mgmt-providers/fault-action-provider.js b/src/providers/fault-mgmt-providers/fault-action-provider.js index ad986293..15f7e741 100644 --- a/src/providers/fault-mgmt-providers/fault-action-provider.js +++ b/src/providers/fault-mgmt-providers/fault-action-provider.js @@ -44,7 +44,7 @@ export default class FaultActionProvider { /** * @typedef {Object} ShelveDuration * @property {string} name - The name of the shelve duration - * @property {number|null} value - The value of the shelve duration in milliseconds, or null for indefinite + * @property {number|null} value - The value of the shelve duration in milliseconds, or null for unlimited */ /** @@ -65,7 +65,7 @@ export default class FaultActionProvider { value: 900000 }, { - name: 'Indefinite', + name: 'Unlimited', value: null } ]; From cb395aaf900017548a61f0cf273c98abe2b13ba6 Mon Sep 17 00:00:00 2001 From: "Mazzella, Jesse D. (ARC-TI)[KBR Wyle Services, LLC]" Date: Wed, 16 Oct 2024 09:22:06 -0700 Subject: [PATCH 2/2] fix: update shelve durations for parity with yamcs --- .../fault-action-provider.js | 20 +++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/src/providers/fault-mgmt-providers/fault-action-provider.js b/src/providers/fault-mgmt-providers/fault-action-provider.js index 15f7e741..2934bc9b 100644 --- a/src/providers/fault-mgmt-providers/fault-action-provider.js +++ b/src/providers/fault-mgmt-providers/fault-action-provider.js @@ -53,16 +53,24 @@ export default class FaultActionProvider { getShelveDurations() { return [ { - name: '5 Minutes', - value: 300000 + name: '15 Minutes', + value: 1000 * 60 * 15 }, { - name: '10 Minutes', - value: 600000 + name: '30 Minutes', + value: 1000 * 60 * 30 }, { - name: '15 Minutes', - value: 900000 + name: '1 Hour', + value: 1000 * 60 * 60 + }, + { + name: '2 Hours', + value: 1000 * 60 * 60 * 2 + }, + { + name: '1 Day', + value: 1000 * 60 * 60 * 24 }, { name: 'Unlimited',