Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix md5 sum of array field type #24

Closed
wants to merge 1 commit into from

Conversation

kt3k
Copy link

@kt3k kt3k commented Apr 16, 2019

This PR tries to fix md5 sum calculation. If the message has the field float64[36] covariance, the current implementation uses float64 covariance for its md5 text. This PR fixes it to float64[36] covariance.

I got c23e848cf1b7533a8d7c259073a97e6f for geometry_msgs/PoseWithCovariance message type with this change, which corresponds to rosmsg md5 output of the type.


fixes #23

@cjds
Copy link

cjds commented Apr 16, 2019

@kt3k We've been trying to keep our fork https://github.com/fetchrobotics/rosgo more up to date because I don't think @akio is accepting PRs. (@akio feel free to correct me and we will start contributing back). I think we already fixed this but we'd welcome your change on our fork

@kt3k
Copy link
Author

kt3k commented Apr 17, 2019

@cjds
Great! I confirmed your fork has already addressed this issue. (And it seems addressing further cases according to the source code 👏 ) Thank you for the info!

@kt3k kt3k force-pushed the feature/fix-md5-array-type branch from 64ed95b to 2e44ecb Compare June 14, 2019 10:21
@kt3k
Copy link
Author

kt3k commented Jan 6, 2020

We moved to our own fork https://github.com/seqsense/rosgo

I'm sorry that we can't collaborate well on this.

@akio We can help this project if you restart the development and maintainance.

@kt3k kt3k closed this Jan 6, 2020
@cjds
Copy link

cjds commented Jan 6, 2020

@kt3k if you're interested in PRing to our fork, we'd be interested in being the cannonical source for rosgo. I noticed you put in .13 support to your fork which we haven't done yet. But if we have a single source tree between us we can get each others changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

md5 checksum of geometry_msgs/PoseWithCovariance is wrong
2 participants