Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes in HA 2024.1 beta #1463

Open
codyc1515 opened this issue Dec 30, 2023 · 2 comments · Fixed by #1461
Open

Breaking changes in HA 2024.1 beta #1463

codyc1515 opened this issue Dec 30, 2023 · 2 comments · Fixed by #1461

Comments

@codyc1515
Copy link
Contributor

Integration is failing to load in 2024.1 due to following error.

Logger: homeassistant.helpers.entity
Source: helpers/entity.py:894
First occurred: December 30, 2023 at 23:57:55 (12 occurrences)
Last logged: 00:08:54

Update for vacuum.kitchen_robot fails
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 894, in async_update_ha_state
    await self.async_device_update()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1212, in async_device_update
    await self.async_update()
  File "/config/custom_components/xiaomi_miot/vacuum.py", line 121, in async_update
    await super().async_update()
  File "/config/custom_components/xiaomi_miot/__init__.py", line 1510, in async_update
    await self.async_update_for_main_entity()
  File "/config/custom_components/xiaomi_miot/__init__.py", line 1551, in async_update_for_main_entity
    self._update_sub_entities(
  File "/config/custom_components/xiaomi_miot/__init__.py", line 2127, in _update_sub_entities
    self._subs[fnm] = MiotSensorSubEntity(self, p, option=opt)
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/xiaomi_miot/sensor.py", line 490, in __init__
    super().__init__(parent, miot_property, option, domain=ENTITY_DOMAIN)
  File "/config/custom_components/xiaomi_miot/__init__.py", line 2524, in __init__
    self._attr_native_unit_of_measurement = miot_property.unit_of_measurement
                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/xiaomi_miot/core/miot_spec.py", line 748, in unit_of_measurement
    'celsius': TEMP_CELSIUS,
               ^^^^^^^^^^^^
NameError: name 'TEMP_CELSIUS' is not defined
@codyc1515
Copy link
Contributor Author

#1461
#1459

@al-one al-one linked a pull request Dec 31, 2023 that will close this issue
@javato
Copy link

javato commented Jan 4, 2024

The fix for this issue is already merged, isn't it?
When a new release will be created so we can update our integration?
Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants