Integration into Blazorise?

[stsrki]

Hi @aladotnet, I found out about your library from another person's recommendation and I find it really good.

I'm a creator of Blazorise component library, and I think your work would fit into Blazorise. I propose that you become a collaborator on Blazorise and then make Blazorise.FluentValidation is a part of Blazorise extensions. That way, you would be part of a larger community, and your work can reach more people. Our team could also improve the library even further. Not to mention that it will always be on time with the latest version releases.

I would like you to consider it. Please let me know what you think.

PS. Not sure what would happen with the NuGet packages. You have published it with a Blazorise.* prefix, and it is usually reserved for Blazorises official releases. We're also in the process of making it an official reservation.

[aladotnet]

Hi,

this repository has been created out of a personal need, i appreciate your feedback and i am also open for merging it into the Blazorise extensions and to be as a contributor a part from the community.

due to the Naming, i had no intense of violating any of your Branding Rights, it just fits in the context of what the Package is implemented for.

so let me know what are the Next steps.

[stsrki]

I'm really glad that you have agreed to make it part of Blazorise. I guess the next step would be for you to create a PR on the Blazorise repository. We could do it for you, but it's better that it comes with your name as that way, we could mention you in our release notes as a contributor.

Once the PR is created, we will review it and modify it to be stable enough for production. Hopefully, it will be enough time to make it for v1.1, but we will see.

The project name would be named Blazorise.FluentValidation, and placed under the Source/Extension along the other similar components.

Regarding the existing NuGet package. I'm afraid it would need to be unlisted. Hopefully, it will not cause any problems when we try to publish a new version.

[stsrki]

Hi @aladotnet, I have started with Blazorise integration and I have a question.

In the sample project, you're validating two times.

But from what I can see while testing doing the await fluentValidations.ValidateAll() is enough. So PersonValidator.ValidateAsync is not needed. Can you tell me what are the reasons to have it?

[stsrki]

Megabit/Blazorise#4068

[aladotnet]

Hi, sorry that i did not reply that fast, i was very busy the last days, i ll take a look at it tomorrow, if it is ok for you.

[aladotnet]

Yes your right, there is no reason for calling ValidateAll, i think i just forgot to delete it.

[stsrki]

Yes your right, there is no reason for calling ValidateAll, i think i just forgot to delete it.

Great, thank you.

[aladotnet]

@stsrki should i take some action or have you already did it all?

[stsrki]

I think the actual PR is ready to be merged. I just need a final review from David.

The only thing left would be the NuGet feed. TBH, I don't know if publishing the same-named NuGet package is possible. Blazorise v1.1 is scheduled for Sept 15th, so we will need to figure it out by then.

[stsrki]

Hi @aladotnet, the Blazorise release date is coming soon, so it would be great if we could handle the NuGet feed as soon as possible. Is there any way I can contact you other than here? Discord or Gitter?

[aladotnet]

Hi @stsrki, i think there is a way to transfer the packages ownership (https://devblogs.microsoft.com/nuget/managing-package-owners/), i ll contact you via gitter

[stsrki]

That sounds great.