Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print SRE FQDN when deployment finishes #2297

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Print SRE FQDN when deployment finishes #2297

wants to merge 2 commits into from

Conversation

craddm
Copy link
Contributor

@craddm craddm commented Nov 15, 2024

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

🚦 Depends on

⤴️ Summary

Exports the sre_fqdn to the SRE stack, prints the FQDN at the end of the deployment process.

🌂 Related issues

Closes #2274

🔬 Tests

Tested locally

@craddm craddm changed the title Print sre fqdn Print SRE FQDN when deployment finishes Nov 15, 2024
@github-actions GitHub Actions
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  data_safe_haven/commands
  sre.py 166
  data_safe_haven/infrastructure/programs
  declarative_sre.py 423
Project Total  

This report was generated by python-coverage-comment-action

@craddm craddm changed the base branch from release-v5.1.0 to develop November 18, 2024 10:58
@craddm craddm marked this pull request as ready for review November 19, 2024 14:50
@craddm craddm requested a review from a team as a code owner November 19, 2024 14:50
JimMadge
JimMadge reviewed Nov 19, 2024
View reviewed changes
Copy link
Member

@JimMadge JimMadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, could we have an example of the output?

data_safe_haven/commands/sre.py
@@ -162,6 +162,12 @@ def deploy(
timezone=sre_config.sre.timezone,
)
manager.run()

console.print(
f"Secure Research Environment '[green]{name}[/]' has been successfully deployed. \n"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
f"Secure Research Environment '[green]{name}[/]' has been successfully deployed. \n"
f"Secure Research Environment '[green]{name}[/]' has been successfully deployed.\n"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimMadge JimMadge JimMadge left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@craddm craddm

Labels
None yet
Projects
Data Safe Haven
Status: In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show the Guacamole URL on the terminal after creating an SRE
2 participants
@craddm @JimMadge