Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add symfony 5.0 dependency #22

Open
jfsenechal opened this issue Mar 20, 2020 · 2 comments · May be fixed by #23
Open

Add symfony 5.0 dependency #22

jfsenechal opened this issue Mar 20, 2020 · 2 comments · May be fixed by #23

Comments

@jfsenechal
Copy link

Hello,

Do you think your library would work with symfony/http-foundation 5.0 ?

Thank you

@gnutix gnutix linked a pull request Mar 31, 2020 that will close this issue
@spackmat
Copy link

spackmat commented Aug 27, 2020

I see two occurrences of the HttpFoundation dependency: Both are very simple cases of usage of its File class. So I don't expect any limitations about Symfony 5 compatibility. Is there another reason, why that super simple PR is not accepted since march?

The limitation on Symfony 4 prevents me from updating my project to Symfony 5.1 now (I really don't know why it didn't prevent the Upgrade to 5.0 before, because it should have).

So please could you accept the PR and release a new version?

In the meantime, I used the branch from the PR #23 in my composer.json, by adding the repository and the specific branch:

{
  "repositories": [
    {
      "type": "git",
      "url": "https://github.com/gnutix/PHP-dataURI"
    }
  ],
  "require": {
    "other/dependencies": "^1.0",
    "data-uri/data-uri": "dev-patch-1"
  }
}

Thnaks @gnutix !

@ghispi
Copy link

ghispi commented Jun 28, 2021

If you just need to get decoded data from data uri use https://www.php.net/manual/en/wrappers.data.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants