Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update AlchemySigner docs #701

Closed
kevinweaver opened this issue Jun 3, 2024 · 1 comment
Closed

docs: Update AlchemySigner docs #701

kevinweaver opened this issue Jun 3, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@kevinweaver
Copy link

kevinweaver commented Jun 3, 2024

Is this a request for new documentation or updates to existing documentation
Existing Documentation

If existing documentation, a clear summary of what needs to be changed
The AlchemySigner docs suggest using the AlchemySigner type, which is deprecated with a comment suggesting the use of AlchemyWebSigner. This type is entirely absent from docs, so it's possible this comment is a typo as well, perhaps AlchemySmartSigner or SmartAccountSigner are intended?

If new documentation, a clear summary of what needs to be added
Please update the docs if AlchemySigner is truly deprecated and differentiate between:

  • AlchemySigner
  • AlchemyWebSigner
  • AlchemySmartSigner
  • SmartAccountSigner
  • LocalAccountSigner
    as different docs point to each of these.

Additional context
Additional documentation issue here.

@kevinweaver kevinweaver added the documentation Improvements or additions to documentation label Jun 3, 2024
@moldy530
Copy link
Collaborator

this should all be up to date in the v4 docs now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants