Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: do not allow uninstall plug-in if only one installed - avoid bricked accounts #885

Open
avarobinson opened this issue Jul 31, 2024 · 0 comments
Assignees

Comments

@avarobinson
Copy link
Collaborator

avarobinson commented Jul 31, 2024

Is your feature request related to a problem? Please describe.
Bricked accounts can occur when uninstalling plug-ins if there is only 1 plug-in installed. For example, using a createAlchemyModularAccountClient will default install multi-owner plugin. If you uninstall this plugin in a single action, the account will no longer have a validation function and will become bricked.

Valid use case: adding on multi-sig functionality to a modular account

Describe the solution you would like

  • when calling uninstallPlugin actions, enforce that more than 1 plugin is installed, and throw if it's the last plugin
  • can use getInstalledPlugins().length == 1 for a check

Describe alternatives you have considered

  • Expose MA action that allows for simple switch from MA with one owner to multi-sig ownership (this will avoid requiring calldata to be encoded manually and can be exposed with account actions instead)
  • This should be a fast follow to the check for currently installed plugins

Additional context
Related discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants