Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(error): use unexpected error instead #761

Merged
merged 3 commits into from
Aug 7, 2024
Merged

feat(error): use unexpected error instead #761

merged 3 commits into from
Aug 7, 2024

Conversation

0xfourzerofour
Copy link
Collaborator

@0xfourzerofour 0xfourzerofour commented Aug 7, 2024 •
edited
Loading

Proposed Changes

  • Log pool closed error and just propagate the UnexpectedResponse error instead. We do not really want to be saying that the pool sender has closed in rpc responses
  • Check that the gas price is not equal to zero before calculating the dynamic gas as this will lead to an integer overflow

@codecov Codecov
Copy link

codecov bot commented Aug 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 36.36364% with 7 lines in your changes missing coverage. Please review.

Project coverage is 57.55%. Comparing base (a88a4c7) to head (1543057).

Files Patch % Lines
crates/pool/src/server/local.rs 50.00% 4 Missing ⚠️
crates/sim/src/gas/gas.rs 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files Coverage Δ
crates/sim/src/precheck.rs 77.55% <ø> (+0.15%) ⬆️
crates/sim/src/gas/gas.rs 82.38% <0.00%> (-1.75%) ⬇️
crates/pool/src/server/local.rs 47.63% <50.00%> (-0.25%) ⬇️
Flag Coverage Δ
unit-tests 57.55% <36.36%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <ø> (ø)
builder 60.59% <ø> (ø)
dev 0.00% <ø> (ø)
pool 64.46% <50.00%> (-0.03%) ⬇️
provider 16.10% <ø> (ø)
rpc 25.63% <ø> (ø)
sim 78.49% <0.00%> (-0.05%) ⬇️
tasks ∅ <ø> (∅)
types 66.68% <ø> (ø)
utils 18.28% <ø> (ø)

@0xfourzerofour 0xfourzerofour merged commit d1eaffd into main Aug 7, 2024
6 of 7 checks passed
@0xfourzerofour 0xfourzerofour deleted the josh/pool-error branch August 7, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andysim3d andysim3d andysim3d approved these changes

@dancoombs dancoombs Awaiting requested review from dancoombs dancoombs is a code owner

@dphilipson dphilipson Awaiting requested review from dphilipson dphilipson is a code owner

@alex-miao alex-miao Awaiting requested review from alex-miao alex-miao is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xfourzerofour @andysim3d