Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix(STO-020): check entity stake for new account" #770

Closed
wants to merge 1 commit into from
Closed

Revert "fix(STO-020): check entity stake for new account" #770

wants to merge 1 commit into from

Conversation

andysim3d
Copy link
Collaborator

Reverts #765

@codecov Codecov
Copy link

codecov bot commented Aug 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 57.55%. Comparing base (376d552) to head (b3197bb).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
crates/sim/src/simulation/simulator.rs 77.77% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
crates/sim/src/simulation/simulator.rs 84.03% <77.77%> (-0.24%) ⬇️
Flag Coverage Δ
unit-tests 57.55% <77.77%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <ø> (ø)
builder 60.59% <ø> (ø)
dev 0.00% <ø> (ø)
pool 64.46% <ø> (ø)
provider 16.10% <ø> (ø)
rpc 25.63% <ø> (ø)
sim 78.49% <77.77%> (-0.05%) ⬇️
tasks ∅ <ø> (∅)
types 66.68% <ø> (ø)
utils 18.28% <ø> (ø)

0xfourzerofour
0xfourzerofour reviewed Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@0xfourzerofour 0xfourzerofour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the commit message

@andysim3d andysim3d closed this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xfourzerofour 0xfourzerofour 0xfourzerofour left review comments

@dancoombs dancoombs Awaiting requested review from dancoombs dancoombs is a code owner

@dphilipson dphilipson Awaiting requested review from dphilipson dphilipson is a code owner

@alex-miao alex-miao Awaiting requested review from alex-miao alex-miao is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andysim3d @0xfourzerofour