-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable T
in VarLenArray<T>
to also contain a VarLenArray
#232
base: master
Are you sure you want to change the base?
Conversation
…limoen/hdf5-rust into mulimoen-feature/static-multi-versions
This PR contains tons of unrelated changes and will need rebasing and cleaning, however that's not even the main issue here. You can't simply change One way to restrict it, I guess, would be adding something like pub trait VarLenElement: 'static + Clone {}
impl<T: Copy> VarLenElement for T {}
impl<T: VarLenElement> VarLenElement for VarLenArray<T> {}
impl VarLenElement for VarLenString {} and then require And then it would need some tests to make sure it actually works. |
This fixes #222.
Additionally, I was implementing a custom filter and required access to the h5err macro, hence the changes to the macro exporting.