Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add golangci-lint to project #28

Open
ccoVeille opened this issue Aug 6, 2024 · 6 comments
Open

add golangci-lint to project #28

ccoVeille opened this issue Aug 6, 2024 · 6 comments
Assignees
Labels
ci/cd Something about CI/CD

Comments

@ccoVeille
Copy link
Collaborator

I can help you in adding golangci-lint to your project and GitHub action workflow

Please let me know if you are interested

@ccoVeille ccoVeille self-assigned this Aug 6, 2024
@alegrey91
Copy link
Owner

Hi @ccoVeille, that would be a great improvement for the code quality.
I'm definitely interested in :)

@ccoVeille
Copy link
Collaborator Author

Great then.

I might not be able to work on it in the next 3 weeks.

I'm only using my phone for now

@alegrey91
Copy link
Owner

Don't worry, there's no rush for this issue

@alegrey91
Copy link
Owner

Hey @ccoVeille , any news on this?

@ccoVeille
Copy link
Collaborator Author

Don't worry, there's no rush for this issue

Oh I assume, I spilled out the "no rush".

Haha.

Let me try

@ccoVeille
Copy link
Collaborator Author

Wow, you set up is quite a nightmare with the folder that should be excluded from analysis.

I found a way to make it works with golangci-lint, but it's highly uncommon

ccoVeille added a commit to ccoveille-forks/alegrey91-harpoon that referenced this issue Sep 8, 2024
The ebpf libraries are not helping at all.

Fix alegrey91#28
ccoVeille added a commit to ccoveille-forks/alegrey91-harpoon that referenced this issue Sep 8, 2024
The ebpf libraries are not helping at all.

Fix alegrey91#28
ccoVeille added a commit to ccoveille-forks/alegrey91-harpoon that referenced this issue Sep 8, 2024
The ebpf libraries are not helping at all.

Fix alegrey91#28
ccoVeille added a commit to ccoveille-forks/alegrey91-harpoon that referenced this issue Sep 8, 2024
The ebpf libraries are not helping at all.

Fix alegrey91#28
@alegrey91 alegrey91 added the ci/cd Something about CI/CD label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Something about CI/CD
Projects
None yet
Development

No branches or pull requests

2 participants