Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request on feature branch because of needed review #393

Open
baedorf opened this issue Jun 2, 2023 · 5 comments
Open

Pull request on feature branch because of needed review #393

baedorf opened this issue Jun 2, 2023 · 5 comments

Comments

@baedorf
Copy link

baedorf commented Jun 2, 2023

Normally, I would implement a feature and a colleage should review the implementation before merging the feature into develop.
After finishing the review, the plugin should be executed to merge feature into develop.
Is this possible?

@aleksandr-m
Copy link
Owner

@baedorf What exactly? What do you want plugin to do?

@baedorf
Copy link
Author

baedorf commented Jun 12, 2023

I don't know if its part of gitflow strategy, perhaps I need an additional goal like feature-review.
This should create a pull request. Within this pull request, a code reviews can be performed. After review is finished (organizational task), feature-finish should merge pull request and update dependencies/versions like in actual implementation.

@aleksandr-m
Copy link
Owner

Pull request where?
For example when using gitlab, merge requests can be created using git push options. See readme to configure this in plugin.

@baedorf
Copy link
Author

baedorf commented Jun 13, 2023

I need the for github and can't find push options as linked in gitlab.
Could you please provide an example on how to perform this with yout plugin?

@aleksandr-m
Copy link
Owner

AFAIK GitHub doesn't provide means of automatically creating PR-s from commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants