Feature: aleph settings services #248
Merged
+249
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
1yam
force-pushed
the
1yam-network-settings-services
branch
from
5ba3de0 to
82d47e9
Compare
1yam
changed the base branch from
main
to
andres-feature-implement_ledger_wallet
1yam
changed the base branch from
andres-feature-implement_ledger_wallet
to
main
nesitor
reviewed
Nov 27, 2025
Solution: Implement Ledger use on SDK to allow using them.
1yam
force-pushed
the
1yam-network-settings-services
branch
from
82d47e9 to
88c5aff
Compare
Co-authored-by: nesitor <amolinsdiaz@yahoo.es>
…s for pricing and settings
nesitor
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: 658
This PR goal is to add a new service
Settingsto be able to fetch currents network settings on:Network Settings Aggregates
This pull request introduces a new service for accessing network settings, specifically focused on retrieving GPU compatibility and related network configuration data. The main changes include the addition of the
Settingsservice, integration of this service into the main HTTP client, and the creation of comprehensive unit tests to validate its behavior.New Network Settings Service:
Settingsservice (Settingsclass) insrc/aleph/sdk/client/services/settings.pyto handle logic around network settings, including a model (NetworkSettingsModel) for compatible GPUs and other network configuration fields.get_settings_aggregatein theSettingsservice to fetch configuration data from the aggregate using a specific address.Integration:
Settingsservice asself.settingswithin the main HTTP client (AlephHttpClient) for easier access to network settings. [1] [2]Testing:
tests/unit/services/test_settings.pythat mocks the aggregate response and verifies the correct parsing and retrieval of GPU compatibility and other network settings.NB: this PR is based on ledger one since we fixed some bugs, refactor some heavy logic