Add more tests

Author: Lbqds

test/shareProcessorTest.js

@@ -84,8 +84,7 @@ describe('test share processor', function(){
         shareProcessor.redisClient = redisClient;
 
         var shares = {'miner0': '4', 'miner1': '2', 'miner2': '2'};
-        var blockData = {hash: '0011', fromGroup: 0, toGroup: 1, height: 1, rewardAmount: '40000000000000000000'};
-        var block = {pendingBlockValue: blockData.hash + ':' + '0', data: blockData};
+        var block = {pendingBlockValue: '0011' + ':' + '0', hash: '0011', fromGroup: 0, toGroup: 1, height: 1, rewardAmount: '40000000000000000000'};
 
         var checkState = function(){
             redisClient
@@ -106,9 +105,9 @@ describe('test share processor', function(){
         }
 
         var roundKey = shareProcessor.roundKey(
-            blockData.fromGroup,
-            blockData.toGroup,
-            blockData.hash
+            block.fromGroup,
+            block.toGroup,
+            block.hash
         );
 
         redisClient
@@ -123,6 +122,69 @@ describe('test share processor', function(){
             });
     })
 
+    it('should reward uncle miners with correct reward amount', function(done){
+        var config = { ...test.config, confirmationTime: 0 }
+        var shareProcessor = new ShareProcessor(config, test.logger);
+        shareProcessor.redisClient = redisClient;
+
+        var currentMs = Date.now();
+        var rewardAmount = '4000000000000000000';
+        var ghostUncleRewardAmount = '2000000000000000000';
+        var ghostUncleCoinbaseTx = [{unsigned:{fixedOutputs:[{attoAlphAmount: rewardAmount}]}}];
+        var ghostUncleBlock = {hash: 'block1', height: 1, chainFrom: 0, chainTo: 0, transactions: ghostUncleCoinbaseTx, inMainChain: false, submittedMs: currentMs, ghostUncles: []}
+
+        var mainChainCoinbaseTx = [{unsigned:{fixedOutputs:[{attoAlphAmount: rewardAmount},{attoAlphAmount: ghostUncleRewardAmount}]}}];
+        var mainChainBlock = {hash: 'block2', height: 2, chainFrom: 0, chainTo: 0, transactions: mainChainCoinbaseTx, inMainChain: true, submittedMs: currentMs, ghostUncles: [{hash:ghostUncleBlock.hash}]}
+        var blocks = [ghostUncleBlock, mainChainBlock]
+
+        function prepare(blocks, callback){
+            var restServer = nock('http://127.0.0.1:12973');
+            var redisTx = redisClient.multi();
+            restServer.persist().get('/blockflow/main-chain-block-by-ghost-uncle/' + ghostUncleBlock.hash).reply(200, mainChainBlock)
+            for (var block of blocks){
+                restServer.persist().get('/blockflow/blocks/' + block.hash).reply(200, block);
+                var isInMainChainPath = '/blockflow/is-block-in-main-chain?blockHash=' + block.hash;
+                restServer.persist().get(isInMainChainPath).reply(200, block.inMainChain ? true : false);
+
+                var blockWithTs = block.hash + ':' + block.submittedMs;
+                redisTx.sadd('pendingBlocks', blockWithTs);
+            }
+
+            redisTx.exec(function(error, _){
+                if (error) assert.fail('Test failed: ' + error);
+                callback(restServer);
+            });
+        }
+
+        prepare(blocks, _ => {
+            shareProcessor.getPendingBlocks(
+                blocks.map(block => block.hash + ':' + block.submittedMs),
+                function(pendingBlocks){
+                    expect(pendingBlocks).to.deep.equal([
+                        {
+                          fromGroup: 0,
+                          hash: "block1",
+                          height: 1,
+                          pendingBlockValue: blocks[0].hash + ':' + blocks[0].submittedMs,
+                          rewardAmount: "2000000000000000000",
+                          toGroup: 0,
+                        },
+                        {
+                          fromGroup: 0,
+                          hash: "block2",
+                          height: 2,
+                          pendingBlockValue: blocks[1].hash + ':' + blocks[1].submittedMs,
+                          rewardAmount: "4000000000000000000",
+                          toGroup: 0
+                        }
+                    ]);
+                    nock.cleanAll();
+                    done();
+                }
+            );
+        });
+    })
+
     it('should remove orphan block and shares', function(done){
         var shareProcessor = new ShareProcessor(test.config, test.logger);
         shareProcessor.redisClient = redisClient;
@@ -137,6 +199,7 @@ describe('test share processor', function(){
             {hash: 'block3', height: 3, chainFrom: 0, chainTo: 0, transactions: transactions, inMainChain: true, submittedMs: currentMs - confirmationTime},
             {hash: 'block4', height: 4, chainFrom: 0, chainTo: 0, transactions: transactions, inMainChain: true, submittedMs: currentMs - confirmationTime},
         ];
+        var orphanBlock = blocks[1];
 
         var shares = {};
         for (var block of blocks){
@@ -146,10 +209,13 @@ describe('test share processor', function(){
         function prepare(blocks, shares, callback){
             var restServer = nock('http://127.0.0.1:12973');
             var redisTx = redisClient.multi();
+            restServer.persist()
+                .get('/blockflow/main-chain-block-by-ghost-uncle/' + orphanBlock.hash)
+                .reply(404, { detail: `Mainchain block by ghost uncle hash ${orphanBlock.hash} not found` });
             for (var block of blocks){
-                restServer.get('/blockflow/blocks/' + block.hash).reply(200, block);
+                restServer.persist().get('/blockflow/blocks/' + block.hash).reply(200, block);
                 var path = '/blockflow/is-block-in-main-chain?blockHash=' + block.hash;
-                restServer.get(path).reply(200, block.inMainChain ? true : false);
+                restServer.persist().get(path).reply(200, block.inMainChain ? true : false);
 
                 var blockWithTs = block.hash + ':' + block.submittedMs;
                 redisTx.sadd('pendingBlocks', blockWithTs);
@@ -171,7 +237,6 @@ describe('test share processor', function(){
         }
 
         var checkState = function(){
-            var orphanBlock = blocks[1];
             var orphanBlockWithTs = orphanBlock.hash + ':' + orphanBlock.submittedMs;
             var roundKey = shareProcessor.roundKey(orphanBlock.chainFrom, orphanBlock.chainTo, orphanBlock.hash);
 
@@ -193,11 +258,11 @@ describe('test share processor', function(){
             var expected = [
                 {
                     pendingBlockValue: blocks[2].hash + ':' + blocks[2].submittedMs,
-                    data: blockData(blocks[2])
+                    ...blockData(blocks[2])
                 },
                 {
                     pendingBlockValue: blocks[3].hash + ':' + blocks[3].submittedMs,
-                    data: blockData(blocks[3])
+                    ...blockData(blocks[3])
                 }
             ];