Skip to content

Commit e48a85f

Browse files
chore: renamed read event to data (#30)
1 parent bc039ce commit e48a85f

File tree

4 files changed

+13
-13
lines changed

4 files changed

+13
-13
lines changed

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,7 @@ The `StreamReader` class extends the `EventEmitter` class, providing events for
245245

246246
```ts
247247
const reader = new StreamReader( ... )
248-
reader.on( 'read', chunk => {
248+
reader.on( 'data', chunk => {
249249
console.log( 'received chunk', chunk )
250250
} )
251251
```
@@ -345,7 +345,7 @@ let resourceSize = 0
345345
if ( response.body ) {
346346
const reader = new StreamReader( response.body )
347347
const decoder = new TextDecoder()
348-
reader.on( 'read', chunk => {
348+
reader.on( 'data', chunk => {
349349
const decoded = decoder.decode( chunk, { stream: true } )
350350
resourceSize += chunk.BYTES_PER_ELEMENT * chunk.length
351351
} )
@@ -368,7 +368,7 @@ const reader = new StreamReader<Buffer, string>( stream.readable )
368368

369369
streamData( { writer } )
370370

371-
reader.on( 'read', chunk => {
371+
reader.on( 'data', chunk => {
372372
console.log( chunk ) // chunk is type of string
373373
} )
374374
const chunks = await reader.read( chunk => chunk.toString( 'base64url' ) ) // `string[]`

__tests__/reader.test.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ describe( 'StreamReader', () => {
4343
streamData( { writer } )
4444

4545
const onRead: OnReadEventListener<Buffer> = jest.fn()
46-
reader.on( 'read', onRead )
46+
reader.on( 'data', onRead )
4747
await reader.read()
4848

4949
expect( onRead ).toHaveBeenCalledTimes( 2 )
@@ -97,12 +97,12 @@ describe( 'StreamReader', () => {
9797

9898
const onRead: OnReadEventListener<Buffer> = jest.fn()
9999
const onClose: OnCloseEventListener<Buffer> = jest.fn()
100-
reader.on( 'read', onRead )
100+
reader.on( 'data', onRead )
101101
reader.on( 'close', onClose )
102102

103103
await reader.read()
104104

105-
expect( reader.listenerCount( 'read' ) ).toBe( 0 )
105+
expect( reader.listenerCount( 'data' ) ).toBe( 0 )
106106
expect( reader.listenerCount( 'close' ) ).toBe( 0 )
107107
} )
108108

@@ -163,7 +163,7 @@ describe( 'StreamReader', () => {
163163

164164
expect( onClose ).toHaveBeenCalledTimes( 0 )
165165
expect( onClose2 ).toHaveBeenCalledTimes( 0 )
166-
expect( reader.listenerCount( 'read' ) ).toBe( 0 )
166+
expect( reader.listenerCount( 'data' ) ).toBe( 0 )
167167
expect( reader.listenerCount( 'close' ) ).toBe( 0 )
168168
} )
169169

@@ -282,7 +282,7 @@ describe( 'StreamReader', () => {
282282

283283
streamData( { writer } )
284284

285-
reader.on( 'read', chunk => {
285+
reader.on( 'data', chunk => {
286286
expect( typeof chunk ).toBe( 'string' )
287287
} )
288288

src/index.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ export class StreamReader<I = unknown, O = I> extends EventEmitter<StreamReaderE
5555
* Asynchronously reads on-demand stream data.
5656
*
5757
* Optionally transform each chunk using the provided transform function.
58-
* Emits a 'read' event for each chunk after it has been processed.
58+
* Emits a 'data' event for each chunk after it has been processed.
5959
* If an error occurs during the reading process, it is caught and passed to the `error` method.
6060
*
6161
* @template I - The type of the input chunks.
@@ -69,7 +69,7 @@ export class StreamReader<I = unknown, O = I> extends EventEmitter<StreamReaderE
6969
for await ( const chunk of this.readChunks() ) {
7070
const processed = ( typeof transform === 'function' ? await transform( chunk ) : chunk ) as ReadChunk<O>
7171
this.receivedChunks.push( processed )
72-
this.emit( 'read', processed )
72+
this.emit( 'data', processed )
7373
}
7474
return (
7575
this.close()
@@ -193,7 +193,7 @@ export class StreamReader<I = unknown, O = I> extends EventEmitter<StreamReaderE
193193
*/
194194
private removeListeners()
195195
{
196-
this.removeAllListeners( 'read' )
196+
this.removeAllListeners( 'data' )
197197
this.removeAllListeners( 'close' )
198198
this.removeAllListeners( 'cancel' )
199199

src/types.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ export type StreamReaderEvents<O = unknown> = {
3838
* Emitted when a chunk of data is read from the stream.
3939
* @param {ReadChunk<O>} chunk - The chunk of data read from the stream.
4040
*/
41-
read: [ chunk: ReadChunk<O> ]
41+
data: [ chunk: ReadChunk<O> ]
4242

4343

4444
/**
@@ -68,7 +68,7 @@ export type StreamReaderEvents<O = unknown> = {
6868
*
6969
* @template O The type of data being read from the stream and eventually transformed before the event is emitted.
7070
*/
71-
export type OnReadEventListener<O = unknown> = Listener<StreamReaderEvents<O>, 'read'>
71+
export type OnReadEventListener<O = unknown> = Listener<StreamReaderEvents<O>, 'data'>
7272

7373

7474
/**

0 commit comments

Comments
 (0)