Merge pull request AY2324S2-CS2103T-T08-1#97 from NatLeong/add-read-tests

Add all tests for ReadCommand and ReadCommandParser

Author: jovantanyk

src/test/java/seedu/address/logic/commands/ReadCommandTest.java

@@ -4,40 +4,49 @@
 import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 import static seedu.address.logic.commands.CommandTestUtil.NON_EXISTENT_NRIC;
-import static seedu.address.testutil.TypicalPersons.BOB;
+import static seedu.address.logic.commands.CommandTestUtil.assertCommandFailure;
+import static seedu.address.logic.commands.CommandTestUtil.assertCommandSuccess;
+import static seedu.address.logic.commands.ReadCommand.MESSAGE_READ_PERSON_SUCCESS;
+import static seedu.address.model.Model.PREDICATE_SHOW_ALL_PERSONS;
+import static seedu.address.testutil.TypicalPersons.ALICE;
 import static seedu.address.testutil.TypicalPersons.getTypicalAddressBook;
 
 import org.junit.jupiter.api.Test;
 
+import seedu.address.logic.Messages;
 import seedu.address.model.Model;
 import seedu.address.model.ModelManager;
 import seedu.address.model.UserPrefs;
 import seedu.address.model.person.Nric;
 
 public class ReadCommandTest {
 
-    private Model model = new ModelManager(getTypicalAddressBook(), new UserPrefs());
-
-    /*@Test
+    private final Model model = new ModelManager(getTypicalAddressBook(), new UserPrefs());
+    private final Model expectedModel = new ModelManager(getTypicalAddressBook(), new UserPrefs());
+    @Test
     void execute_validNric_success() {
-
+        String expectedMessage = String.format(MESSAGE_READ_PERSON_SUCCESS, Messages.formatRead(ALICE));
+        ReadCommand command = new ReadCommand(ALICE.getNric());
+        expectedModel.updateFilteredPersonList(PREDICATE_SHOW_ALL_PERSONS);
+        assertCommandSuccess(command, model, expectedMessage, expectedModel);
     }
 
     @Test
-    void execute_invalidNric_failure() {
-
-    }*/
+    void execute_nonExistentNric_failure() {
+        Nric nonexistentNric = new Nric("S1234567A");
+        assertCommandFailure(new ReadCommand(nonexistentNric), model, Messages.MESSAGE_PERSON_NOT_FOUND);
+    }
 
     @Test
     void equals() {
-        ReadCommand readFirstCommand = new ReadCommand(BOB.getNric());
+        ReadCommand readFirstCommand = new ReadCommand(ALICE.getNric());
         ReadCommand readSecondCommand = new ReadCommand(new Nric(NON_EXISTENT_NRIC));
 
         // same object -> returns true
         assertTrue(readFirstCommand.equals(readFirstCommand));
 
         // same values -> returns true
-        ReadCommand readFirstCommandCopy = new ReadCommand(BOB.getNric());
+        ReadCommand readFirstCommandCopy = new ReadCommand(ALICE.getNric());
         assertTrue(readFirstCommand.equals(readFirstCommandCopy));
 
         // different types -> returns false
@@ -52,8 +61,8 @@ void equals() {
 
     @Test
     void testToString() {
-        ReadCommand readCommand = new ReadCommand(BOB.getNric());
-        String expected = ReadCommand.class.getCanonicalName() + "{nric=" + BOB.getNric() + "}";
+        ReadCommand readCommand = new ReadCommand(ALICE.getNric());
+        String expected = ReadCommand.class.getCanonicalName() + "{nric=" + ALICE.getNric() + "}";
         assertEquals(expected, readCommand.toString());
     }
 

src/test/java/seedu/address/logic/parser/ReadCommandParserTest.java

@@ -2,6 +2,8 @@
 
 import static seedu.address.logic.Messages.MESSAGE_INVALID_COMMAND_FORMAT;
 import static seedu.address.logic.parser.CommandParserTestUtil.assertParseFailure;
+import static seedu.address.logic.parser.CommandParserTestUtil.assertParseSuccess;
+import static seedu.address.testutil.TypicalPersons.ALICE;
 
 import org.junit.jupiter.api.Test;
 
@@ -14,9 +16,12 @@ public void parse_emptyArg_throwsParseException() {
         assertParseFailure(parser, " ",
                 String.format(MESSAGE_INVALID_COMMAND_FORMAT, ReadCommand.MESSAGE_NOT_READ));
     }
-    /*@Test
-    public void parse_validArgs_returnsReadCommand() {
 
-    }*/
+    @Test
+    public void parse_validArgs_returnsReadCommand() {
+        ReadCommand expectedReadCommand =
+                new ReadCommand(ALICE.getNric());
+        assertParseSuccess(parser, "T0139571B", expectedReadCommand);
+    }
 
 }