Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing active class #3

Closed
oskarrough opened this issue May 19, 2015 · 1 comment · Fixed by #12
Closed

Changing active class #3

oskarrough opened this issue May 19, 2015 · 1 comment · Fixed by #12

Comments

@oskarrough
Copy link

Hi, thanks for this small helper. It's great. Would it be possible for it to take the default activeClass?

We normally change active to is-active in our apps.

Ember.LinkView.reopen({
    activeClass: 'is-active'
});
@alexspeller
Copy link
Owner

I think this makes sense, I'd be happy to accept a PR that did this

@Keeo Keeo mentioned this issue Sep 22, 2015
Closed
@Panman82 Panman82 mentioned this issue Dec 18, 2015
Closed
@Panman82 Panman82 mentioned this issue Mar 4, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@alexspeller @oskarrough