Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template should avoid the --project-name argument in CI/CD definitions for non-workspace projects. #57

Closed
CiottiGiorgio opened this issue Aug 26, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@CiottiGiorgio
Copy link
Member

With this recent AlgoKit PR, the --project-name argument on the CI/CD jobs will be proxied to the underlying script execution causing most run config to fail.

For templates that are not rendered in a workspace type, that argument should not be included.

@CiottiGiorgio CiottiGiorgio added the bug Something isn't working label Aug 26, 2024
@CiottiGiorgio
Copy link
Member Author

This also probably means that the fullstack template should be changed accordingly to add back the --project-name arg.

@aorumbayev
Copy link
Collaborator

@CiottiGiorgio the PR you outlined should only pass the arguments separated with --. --project-name is still a dedicated option registered on run tasks in cli. Can you showcase a reproducible example that passes project name down to task? I wasn't able to replicate by running algokit deploy testnet --project-name 'production_python' on examples. It correctly picked up the production_python name based on behaviour of the registered option rather then forwarding that arg to the underlying python invocation

@CiottiGiorgio
Copy link
Member Author

I couldn't find the bug that prompted this issue and I couldn't reproduce now.
I agree that the expected behavior is in place with a non-workspace project and the CI/CD pipeline though.

We can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants
@aorumbayev @CiottiGiorgio and others