Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replaced requestId double with UUID v7 #32

Merged
merged 3 commits into from
Jul 22, 2024
Merged

chore: replaced requestId double with UUID v7 #32

merged 3 commits into from
Jul 22, 2024

Conversation

kylebeee
Copy link
Collaborator

ℹ Overview

  • switched requestId from double to uuid v7 based string

📝 Related Issues

✅ Acceptance:

  • Conventional Commits

@kylebeee kylebeee requested a review from PhearZero July 15, 2024 07:33
@kylebeee kylebeee force-pushed the chore/switch-to-uuid branch 2 times, most recently from 4fdb2aa to 430f5ff Compare July 17, 2024 22:50
PhearZero
PhearZero requested changes Jul 18, 2024
View reviewed changes
Copy link
Member

@PhearZero PhearZero left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it's working 🔥

Run this and commit the package-lock.json and it should be gtg:

cd ./sites/dapp-ui
npm install algorandfoundation/liquid-auth-js#chore/switch-request-id-to-uuid

This was referenced Jul 18, 2024
Merged
Merged
@kylebeee kylebeee requested a review from PhearZero July 18, 2024 20:02
PhearZero
PhearZero approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@PhearZero PhearZero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PhearZero PhearZero merged commit d77fc1b into develop Jul 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhearZero PhearZero PhearZero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylebeee @PhearZero