From e854f8f86c2267032577b7748cf3607252b705a9 Mon Sep 17 00:00:00 2001 From: matthew Date: Fri, 10 Jan 2025 10:39:31 +0800 Subject: [PATCH] Fix pmd. --- .../config/server/aspect/ConfigChangeAspect.java | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/config/src/main/java/com/alibaba/nacos/config/server/aspect/ConfigChangeAspect.java b/config/src/main/java/com/alibaba/nacos/config/server/aspect/ConfigChangeAspect.java index 0e8284a7d46..7aafed65a8a 100644 --- a/config/src/main/java/com/alibaba/nacos/config/server/aspect/ConfigChangeAspect.java +++ b/config/src/main/java/com/alibaba/nacos/config/server/aspect/ConfigChangeAspect.java @@ -65,6 +65,10 @@ public class ConfigChangeAspect { private static final String ENABLED = "enabled"; + private static final String SCR_TYPE_HTTP = "http"; + + private static final String SCR_TYPE_RPC = "rpc"; + /** * Publish config. */ @@ -119,10 +123,10 @@ Object publishOrUpdateConfigAround(ProceedingJoinPoint pjp) throws Throwable { final String scrType = configRequestInfo.getSrcType(); ConfigChangePointCutTypes configChangePointCutType = null; - if (scrType.equals("http")) { + if (SCR_TYPE_HTTP.equals(scrType)) { // via console or api calls configChangePointCutType = ConfigChangePointCutTypes.PUBLISH_BY_HTTP; - } else if (scrType.equals("rpc")) { + } else if (SCR_TYPE_RPC.equals(scrType)) { // via sdk rpc calls configChangePointCutType = ConfigChangePointCutTypes.PUBLISH_BY_RPC; } @@ -163,10 +167,10 @@ Object removeConfigByIdAround(ProceedingJoinPoint pjp) throws Throwable { String scrType = (String) args[5]; ConfigChangePointCutTypes configChangePointCutType = null; - if (scrType.equals("http")) { + if (SCR_TYPE_HTTP.equals(scrType)) { // via console or api calls configChangePointCutType = ConfigChangePointCutTypes.PUBLISH_BY_HTTP; - } else if (scrType.equals("rpc")) { + } else if (SCR_TYPE_RPC.equals(scrType)) { // via sdk rpc calls configChangePointCutType = ConfigChangePointCutTypes.PUBLISH_BY_RPC; }