Skip to content

Commit d033678

Browse files
committed
added method for permitted params for better readability
1 parent 509ee97 commit d033678

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

app/controllers/api/v1/users_controller.rb

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -169,15 +169,7 @@ def create_user_params
169169
end
170170

171171
def update_user_params
172-
is_admin = PermissionsChecker.new(current_user:, permission_names: 'ManageUsers', current_provider:).call
173-
174-
@update_user_params ||= if external_auth? && is_admin
175-
params.require(:user).permit(:name)
176-
elsif external_auth?
177-
params.require(:user).permit(:password, :avatar, :language, :role_id, :invite_token)
178-
else
179-
params.require(:user).permit(:name, :password, :avatar, :language, :role_id, :invite_token)
180-
end
172+
@update_user_params ||= params.require(:user).permit(permitted_params)
181173
end
182174

183175
def change_password_params
@@ -202,6 +194,14 @@ def valid_domain?
202194
end
203195
false
204196
end
197+
198+
def permitted_params
199+
is_admin = PermissionsChecker.new(current_user:, permission_names: 'ManageUsers', current_provider:).call
200+
201+
return %i[password avatar language role_id invite_token] if external_auth? && !is_admin
202+
203+
%i[name password avatar language role_id invite_token]
204+
end
205205
end
206206
end
207207
end

0 commit comments

Comments
 (0)