Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce call to Scryfall #64

Open
aloisdg opened this issue Nov 4, 2020 · 0 comments
Open

Reduce call to Scryfall #64

aloisdg opened this issue Nov 4, 2020 · 0 comments
Assignees
Labels
help wanted Any issue where external help is more than welcome. must have First priority. We have to do it. performance Any issue where we can improve Inkfathom Proxy performance.

Comments

@aloisdg
Copy link
Owner

aloisdg commented Nov 4, 2020

When someone click on the search button, we grab the decklist. For each non-url line of the decklist, we extract the name, lang, set, etc. Then we do a call to the Scryfall's search API to get all matching answers. Finally we filter matching answers to get the one with a matching printed name. Then we call Scryfall once more to get the picture of the card.

When someone click on the switchButton of a given card, we call the Scryfall's API for a given card to get all the prints urls of the card. Then we load the next url one.

Two ideas:

  • Is there a way to check from the search if there is more that one print of the card? We could avoid one call when there is no other prints available.
  • Could we call another API to get directly the card by printed name, language and set with all available printings? Like this we could use this call instead of the to we are currently doing.

This may be a considerable alteration. We will wait for the end of #43 first.

@aloisdg aloisdg added the performance Any issue where we can improve Inkfathom Proxy performance. label Nov 4, 2020
@aloisdg aloisdg self-assigned this Nov 4, 2020
@aloisdg aloisdg added help wanted Any issue where external help is more than welcome. must have First priority. We have to do it. labels Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Any issue where external help is more than welcome. must have First priority. We have to do it. performance Any issue where we can improve Inkfathom Proxy performance.
Projects
None yet
Development

No branches or pull requests

1 participant