Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protest calculation incorrect in certain scenarios #266

Closed
alopezlago opened this issue Nov 24, 2023 · 1 comment · Fixed by #275
Closed

Protest calculation incorrect in certain scenarios #266

alopezlago opened this issue Nov 24, 2023 · 1 comment · Fixed by #275
Assignees
@alopezlago
Labels
bug Something isn't working High priority High priority issues

Comments

@alopezlago
Copy link
Owner

Repro:

  • Make two teams T1 and T2
  • Question 1: T1 gets 10 on tossup, 20 on bonus (30-0)
  • Question 2: T1 negs, protests. T2 gets 10 on the tossup, gets 30 points on bonus (25-40)
  • Question 3: T2 gets it, 0 on bonus (25-50)

The alert goes away, but the protest still matters (other team loses 40 points, so (40-10)
@alopezlago alopezlago added bug Something isn't working High priority High priority issues labels Nov 24, 2023
@alopezlago alopezlago self-assigned this Nov 24, 2023
@alopezlago
Copy link
Owner Author

Some issues:

  • Isn't removing the other team's buzz
  • Doesn't handle protests against the correctness of a buzz correctly

@alopezlago alopezlago mentioned this issue Dec 20, 2023
Merged
@alopezlago alopezlago linked a pull request Dec 20, 2023 that will close this issue
v1.26.1 - Fix protest matters calculation #275
Merged
alopezlago added a commit that referenced this issue Dec 20, 2023
@alopezlago
v1.26.1 - Fix protest matters calculation (#275)
b36ec1b 
- Fix protest matters calculation (#266)
- Fix issue with debugging unit tests
- Bump version to 1.26.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alopezlago alopezlago

Labels
bug Something isn't working High priority High priority issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v1.26.1 - Fix protest matters calculation alopezlago/MODAQ
1 participant
@alopezlago