Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add black as pronunciation guide color #267

Closed
hftf opened this issue Dec 2, 2023 · 2 comments · Fixed by #272
Closed

Add black as pronunciation guide color #267

hftf opened this issue Dec 2, 2023 · 2 comments · Fixed by #272
Assignees
Labels
enhancement New feature or request Medium priority Medium priority issues

Comments

@hftf
Copy link
Collaborator

hftf commented Dec 2, 2023

MODAQ always renders all text in parentheses in the pronunciation guide color. Black is not an option for pronunciation guide color, but should be an option, because NAQT-style sets use an inverted convention for bracket punctuation: answerlines in parentheses and pronunciation guides in square brackets.

@alopezlago alopezlago added enhancement New feature or request Medium priority Medium priority issues labels Dec 3, 2023
@alopezlago
Copy link
Owner

I had that at one point while implementing it and got rid of it, but I can bring it back

@alopezlago
Copy link
Owner

This should be back in the next version. I think I took it out because it won't play well with dark mode, but the reader can always change the color in that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Medium priority Medium priority issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants