Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a confirmation dialog or "Dead tossup" button to prevent accidentally pressing "Next" twice #271

Open
hftf opened this issue Dec 2, 2023 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers Low priority Low priority issues

Comments

@hftf
Copy link
Collaborator

hftf commented Dec 2, 2023

Since the throw-out/replacement flow is flawed (#212 #245 etc.), add a barrier to preemptively prevent situations that require manually editing prior game state.

@alopezlago
Copy link
Owner

I'm leaning towards marking this as won't fix. For low-scoring games this becomes a hindrance, and I'm not aware of having to throw out questions because tossups were read in the wrong order (though I could be mistaken). The button could be disabled for a short amount of time (250 ms maybe), but that seems like overkill.

@hftf
Copy link
Collaborator Author

hftf commented Dec 3, 2023

I think changing the text of the button to "Next (dead tossup)" or something would be a simple improvement.

@alopezlago alopezlago added enhancement New feature or request good first issue Good for newcomers Low priority Low priority issues labels Dec 20, 2023
@alopezlago
Copy link
Owner

Should it show the label if the tossup has negs but is still dead, or if there's only no buzzes?

@alopezlago
Copy link
Owner

It's a bit unbalanced if "(dead)" is added to the text. "(dead)" has the issue of being less useful if there were negs in the tossup, since it doesn't prevent this accidental case. Other forms like "(unanswered)" are much bulkier though.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers Low priority Low priority issues
Projects
None yet
Development

No branches or pull requests

2 participants