Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing powermark symbol retroactively changes data in .qbj exports but not .json exports #302

Closed
skysomorphic opened this issue Aug 5, 2024 · 1 comment
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@skysomorphic
Copy link

skysomorphic commented Aug 5, 2024

If the powermark symbol is changed mid-game, the points shown in the ui will update accordingly, as well as the data in exported .qbj files. However, .json exports do not update.

Along with #255, a fix to this would be very helpful for tournaments that are using sets with nonstandard formatting.

example

files before powermark change

files after powermark change

note: the set used in these files uses [*] as the powermark (it's also cleared so dw)

@skysomorphic skysomorphic changed the title Changing powermark symbol retroactively change points in .qbj exports but not .json exports Changing powermark symbol retroactively changes data in .qbj exports but not .json exports Aug 5, 2024
@alopezlago alopezlago added bug Something isn't working Medium priority Medium priority issues labels Aug 18, 2024
@alopezlago
Copy link
Owner

The exact value in points isn't really used in GameState (which is what is serialized into the JSON file), we derive all the points from it. Right now it's used to check if something is correct or not (i.e. to make decisions if points > 0). See the comment in IBuzzMarker, which suggests changing the name to something like isCorrect:

https://github.com/alopezlago/MODAQ/blob/e0acfcc3645e966809490332380f1c28f98c6363/src/state/IBuzzMarker.ts#L8C1-L11C20

The one place I see it possibly affecting things is in Cycle.orderedBuzzes, but that's only if you change the neg value, and changing the ordering here shouldn't affect anything:

(buzz.marker.points <= 0 && otherBuzz.marker.points > 0) ||

I'm going to close this as Won't Fix for now. Tools should rely on the QBJ export, which is standardized and can be imported into other tools like Yellowfruit.

@alopezlago alopezlago closed this as not planned Won't fix, can't repro, duplicate, stale Sep 2, 2024
@alopezlago alopezlago added wontfix This will not be worked on and removed Medium priority Medium priority issues labels Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants