From a8409b3f198191c273187e9504f5870061effcb6 Mon Sep 17 00:00:00 2001 From: Jessica Jones Date: Tue, 1 Oct 2024 13:22:27 +0100 Subject: [PATCH] Take down HMRC's UR banner --- app/views/content_items/answer.html.erb | 1 - .../document_collection.html.erb | 1 - app/views/content_items/guide.html.erb | 2 - lib/data/recruitment_banners.yml | 16 +--- test/integration/recruitment_banner_test.rb | 81 ------------------- 5 files changed, 1 insertion(+), 100 deletions(-) delete mode 100644 test/integration/recruitment_banner_test.rb diff --git a/app/views/content_items/answer.html.erb b/app/views/content_items/answer.html.erb index f581b025d..8f0ba9500 100644 --- a/app/views/content_items/answer.html.erb +++ b/app/views/content_items/answer.html.erb @@ -5,5 +5,4 @@ <%= @requested_variant.analytics_meta_tag.html_safe if @requested_variant.present? %> <% end %> -<%= render 'shared/intervention_banner' %> <%= render 'content_items/body_with_related_links' %> diff --git a/app/views/content_items/document_collection.html.erb b/app/views/content_items/document_collection.html.erb index 97f92a238..3424ba746 100644 --- a/app/views/content_items/document_collection.html.erb +++ b/app/views/content_items/document_collection.html.erb @@ -3,7 +3,6 @@ schema: :article ) %> <% end %> -<%= render 'shared/intervention_banner' %>
<%= render 'govuk_publishing_components/components/title', diff --git a/app/views/content_items/guide.html.erb b/app/views/content_items/guide.html.erb index 3fccbf517..0d2e04ae9 100644 --- a/app/views/content_items/guide.html.erb +++ b/app/views/content_items/guide.html.erb @@ -17,8 +17,6 @@ <% content_for :simple_header, true %> -<%= render 'shared/intervention_banner' %> -
<%= render 'govuk_publishing_components/components/title', { title: @content_item.content_title } %> diff --git a/lib/data/recruitment_banners.yml b/lib/data/recruitment_banners.yml index e7ba5ce40..afca6fb0f 100644 --- a/lib/data/recruitment_banners.yml +++ b/lib/data/recruitment_banners.yml @@ -1,3 +1,4 @@ +banners: # Example usage of adding a banner to the banners list: # - name: Banner 1 @@ -8,18 +9,3 @@ # - / # - /foreign-travel-advice -banners: -- name: HMRC banner 29/08/2024 - suggestion_text: "Help improve GOV.UK" - suggestion_link_text: "Sign up to take part in user research (opens in a new tab)" - survey_url: https://survey.take-part-in-research.service.gov.uk/jfe/form/SV_74GjifgnGv6GsMC?Source=BannerList_HMRC_CCG_Compliance - page_paths: - - /government/collections/tax-compliance-detailed-information - - /government/collections/hm-revenue-and-customs-compliance-checks-factsheets - - /difficulties-paying-hmrc - - /tax-help - - /get-help-hmrc-extra-support - - /guidance/voluntary-and-community-sector-organisations-who-can-give-you-extra-support - - /tax-appeals - - /guidance/how-to-get-a-review-of-an-hmrc-decision - - /guidance/tax-disputes-alternative-dispute-resolution-adr diff --git a/test/integration/recruitment_banner_test.rb b/test/integration/recruitment_banner_test.rb deleted file mode 100644 index df391d26b..000000000 --- a/test/integration/recruitment_banner_test.rb +++ /dev/null @@ -1,81 +0,0 @@ -require "test_helper" - -class RecruitmentBannerTest < ActionDispatch::IntegrationTest - def hmrc_banner_survey_url - "https://survey.take-part-in-research.service.gov.uk/jfe/form/SV_74GjifgnGv6GsMC?Source=BannerList_HMRC_CCG_Compliance" - end - - test "HMRC banner 29/08/2024 is displayed on detailed guides of interest" do - detailed_guide = GovukSchemas::Example.find("detailed_guide", example_name: "detailed_guide") - detailed_guide_paths = [ - "/guidance/voluntary-and-community-sector-organisations-who-can-give-you-extra-support", - "/guidance/how-to-get-a-review-of-an-hmrc-decision", - "/guidance/tax-disputes-alternative-dispute-resolution-adr", - ] - - detailed_guide_paths.each do |path| - detailed_guide["base_path"] = path - stub_content_store_has_item(detailed_guide["base_path"], detailed_guide.to_json) - visit detailed_guide["base_path"] - - assert page.has_css?(".gem-c-intervention") - assert page.has_link?("Sign up to take part in user research (opens in a new tab)", href: hmrc_banner_survey_url) - end - end - - test "HMRC banner 29/08/2024 is displayed on document collections of interest" do - document_collection = GovukSchemas::Example.find("document_collection", example_name: "document_collection") - document_collection_paths = [ - "/government/collections/tax-compliance-detailed-information", - "/government/collections/hm-revenue-and-customs-compliance-checks-factsheets", - ] - - document_collection_paths.each do |path| - document_collection["base_path"] = path - stub_content_store_has_item(document_collection["base_path"], document_collection.to_json) - visit document_collection["base_path"] - - assert page.has_css?(".gem-c-intervention") - assert page.has_link?("Sign up to take part in user research (opens in a new tab)", href: hmrc_banner_survey_url) - end - end - - test "HMRC banner 29/08/2024 is displayed on guides of interest" do - guide = GovukSchemas::Example.find("guide", example_name: "guide") - guide_paths = [ - "/difficulties-paying-hmrc", - "/tax-help", - "/get-help-hmrc-extra-support", - "/tax-appeals", - ] - - guide_paths.each do |path| - guide["base_path"] = path - stub_content_store_has_item(guide["base_path"], guide.to_json) - visit guide["base_path"] - - assert page.has_css?(".gem-c-intervention") - assert page.has_link?("Sign up to take part in user research (opens in a new tab)", href: hmrc_banner_survey_url) - end - end - - test "HMRC banner 29/08/2024 is displayed on answer pages of interest" do - answer = GovukSchemas::Example.find("answer", example_name: "answer") - - answer["base_path"] = "/tax-help" - stub_content_store_has_item(answer["base_path"], answer.to_json) - visit answer["base_path"] - - assert page.has_css?(".gem-c-intervention") - assert page.has_link?("Sign up to take part in user research (opens in a new tab)", href: hmrc_banner_survey_url) - end - - test "HMRC banner 29/08/2024 is not displayed on all pages" do - detailed_guide = GovukSchemas::Example.find("detailed_guide", example_name: "detailed_guide") - detailed_guide["base_path"] = "/nothing-to-see-here" - stub_content_store_has_item(detailed_guide["base_path"], detailed_guide.to_json) - visit detailed_guide["base_path"] - - assert_not page.has_css?(".gem-c-intervention") - end -end