Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor existing components to use the new Component class #4156

Closed
4 tasks
Tracked by #5373 ...
romaricpascal opened this issue Sep 27, 2024 · 0 comments · Fixed by #4205
Closed
4 tasks
Tracked by #5373 ...

Refactor existing components to use the new Component class #4156

romaricpascal opened this issue Sep 27, 2024 · 0 comments · Fixed by #4205
Labels
javascript Pull requests that update Javascript code

Comments

@romaricpascal
Copy link
Member

What

Refactor the existing components to use the base Component class introduced by alphagov/govuk-frontend#5327.

This should be done ahead of its release, by publishing a preview for the public-js-api branch.

Why

As a way to use the features we offer in GOV.UK Frontend, as way to test what we'll offer in GOV.UK Frontend before the release, as well as measure any impact on the final bundle (hopefully in the shape of a small file size reduction due to code being shared in the base Component class

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

  • We've created a preview of GOV.UK Frontend's public-js-api branch
  • We've create a branch of the Design System site using that preview
  • We've refactor the components of the Design System site to use the base Component class where possible
  • We've reviewed the impacts of the refactoring
@romaricpascal romaricpascal added the javascript Pull requests that update Javascript code label Sep 27, 2024
@romaricpascal romaricpascal changed the title Refactor existing components to use the new base component class Refactor existing components to use the new Component class Oct 10, 2024
@romaricpascal romaricpascal linked a pull request Oct 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code
Projects
Status: Done 🏁
Development

Successfully merging a pull request may close this issue.

1 participant