You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
If you open the help screen from the menu, then click anywhere, the help screen closes.
The current behaviour makes it impossible to select text on the help page, either for copy/paste or for other use-cases of text highlighting like tracking your reading position.
To Reproduce
Steps to reproduce the behaviour:
Open the dropdown menu.
Click on 'help'.
Click anywhere on the screen, including the help popup itself.
The popup will close when you release your mouse button.
Expected behaviour
I would expect that the help screen would only close when clicking on the 'Close' button, or outside the bounds of the help screen.
Environment:
Tested on Chrome 115.0.5790.170 and Firefox 116.0.2, both on a Windows 10 desktop.
This sets the click event callback for the dialog itself, rather than the close button within the dialog. The close button itself does not have a click event handler at all, so when you click the button the event bubbles up to the parent dialog element. I suspect this was a case of mistakenly applying the close callback to the dialog element rather than the button element.
The text was updated successfully, but these errors were encountered:
Describe the bug
If you open the help screen from the menu, then click anywhere, the help screen closes.
The current behaviour makes it impossible to select text on the help page, either for copy/paste or for other use-cases of text highlighting like tracking your reading position.
To Reproduce
Steps to reproduce the behaviour:
Expected behaviour
I would expect that the help screen would only close when clicking on the 'Close' button, or outside the bounds of the help screen.
Environment:
Tested on Chrome 115.0.5790.170 and Firefox 116.0.2, both on a Windows 10 desktop.
Additional context
The relevant code is:
my.alt-text.org/src/core.js
Lines 78 to 80 in aeb3cc1
This sets the
click
event callback for the dialog itself, rather than the close button within the dialog. The close button itself does not have aclick
event handler at all, so when you click the button the event bubbles up to the parent dialog element. I suspect this was a case of mistakenly applying the close callback to thedialog
element rather than thebutton
element.The text was updated successfully, but these errors were encountered: