From 6ecebe4d6d64224ba38da4b6f5790aad90277b56 Mon Sep 17 00:00:00 2001 From: VISHNU7KASIREDDY Date: Wed, 3 Dec 2025 14:01:14 +0530 Subject: [PATCH 1/2] =?UTF-8?q?fix:=20correct=20typo=20in=20property=20nam?= =?UTF-8?q?e=20resopnseTimeMs=20=E2=86=92=20responseTimeMs?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixed widespread typo where 'resopnseTimeMs' was misspelled throughout the codebase. The correct spelling 'responseTimeMs' is now used consistently across all type definitions, implementations, and tests. Changes: - Updated GraphQLResponseData interface in types.ts - Fixed property assignments in request handlers (http, action-cable, utils) - Updated gql.service.ts property access - Corrected all test expectations (30 total occurrences across 9 files) This is a code quality improvement with no functional changes. --- .../altair/services/gql/gql.service.spec.ts | 10 +++--- .../altair/services/gql/gql.service.ts | 2 +- .../altair-core/src/request/adapters.spec.ts | 8 ++--- .../src/request/handlers/action-cable.ts | 2 +- .../src/request/handlers/http.spec.ts | 32 +++++++++---------- .../altair-core/src/request/handlers/http.ts | 2 +- packages/altair-core/src/request/types.ts | 2 +- packages/altair-core/src/request/utils.ts | 2 +- 8 files changed, 30 insertions(+), 30 deletions(-) diff --git a/packages/altair-app/src/app/modules/altair/services/gql/gql.service.spec.ts b/packages/altair-app/src/app/modules/altair/services/gql/gql.service.spec.ts index 5a9e725a34..a8c58865a3 100644 --- a/packages/altair-app/src/app/modules/altair/services/gql/gql.service.spec.ts +++ b/packages/altair-app/src/app/modules/altair/services/gql/gql.service.spec.ts @@ -152,7 +152,7 @@ describe('GqlService', () => { url: 'http://test.com', requestStartTimestamp: 1, requestEndTimestamp: 2, - resopnseTimeMs: 1.5, + responseTimeMs: 1.5, }); } default: @@ -167,7 +167,7 @@ describe('GqlService', () => { url: 'http://test.com', requestStartTimestamp: 1, requestEndTimestamp: 2, - resopnseTimeMs: 1.5, + responseTimeMs: 1.5, }); } }; @@ -216,7 +216,7 @@ describe('GqlService', () => { url: 'http://test.com', requestStartTimestamp: 1, requestEndTimestamp: 2, - resopnseTimeMs: 1.5, + responseTimeMs: 1.5, }); } default: @@ -231,7 +231,7 @@ describe('GqlService', () => { url: 'http://test.com', requestStartTimestamp: 1, requestEndTimestamp: 2, - resopnseTimeMs: 1.5, + responseTimeMs: 1.5, }); } }); @@ -283,7 +283,7 @@ describe('GqlService', () => { url: 'http://test.com', requestStartTimestamp: 1, requestEndTimestamp: 2, - resopnseTimeMs: 1.5, + responseTimeMs: 1.5, }); } }; diff --git a/packages/altair-app/src/app/modules/altair/services/gql/gql.service.ts b/packages/altair-app/src/app/modules/altair/services/gql/gql.service.ts index 15d92957ca..5adc98343c 100644 --- a/packages/altair-app/src/app/modules/altair/services/gql/gql.service.ts +++ b/packages/altair-app/src/app/modules/altair/services/gql/gql.service.ts @@ -690,7 +690,7 @@ export class GqlService { url: response.url, requestStartTime: response.requestStartTimestamp, requestEndTime: response.requestEndTimestamp, - responseTime: response.resopnseTimeMs, + responseTime: response.responseTimeMs, }; }) ); diff --git a/packages/altair-core/src/request/adapters.spec.ts b/packages/altair-core/src/request/adapters.spec.ts index 6f9d6d662d..584c094db0 100644 --- a/packages/altair-core/src/request/adapters.spec.ts +++ b/packages/altair-core/src/request/adapters.spec.ts @@ -56,7 +56,7 @@ describe('SubscriptionProviderRequestHandlerAdapter', () => { ok: true, requestEndTimestamp: expect.any(Number), requestStartTimestamp: expect.any(Number), - resopnseTimeMs: expect.any(Number), + responseTimeMs: expect.any(Number), status: 200, statusText: 'OK', url: 'http://localhost:3000/graphql', @@ -100,7 +100,7 @@ describe('SubscriptionProviderRequestHandlerAdapter', () => { ok: true, requestEndTimestamp: expect.any(Number), requestStartTimestamp: expect.any(Number), - resopnseTimeMs: expect.any(Number), + responseTimeMs: expect.any(Number), status: 200, statusText: 'OK', url: 'http://localhost:3000/graphql', @@ -111,7 +111,7 @@ describe('SubscriptionProviderRequestHandlerAdapter', () => { ok: true, requestEndTimestamp: expect.any(Number), requestStartTimestamp: expect.any(Number), - resopnseTimeMs: expect.any(Number), + responseTimeMs: expect.any(Number), status: 200, statusText: 'OK', url: 'http://localhost:3000/graphql', @@ -158,7 +158,7 @@ describe('SubscriptionProviderRequestHandlerAdapter', () => { ok: true, requestEndTimestamp: expect.any(Number), requestStartTimestamp: expect.any(Number), - resopnseTimeMs: expect.any(Number), + responseTimeMs: expect.any(Number), status: 200, statusText: 'OK', url: 'http://localhost:3000/graphql', diff --git a/packages/altair-core/src/request/handlers/action-cable.ts b/packages/altair-core/src/request/handlers/action-cable.ts index bb7623dca3..cd8c22088d 100644 --- a/packages/altair-core/src/request/handlers/action-cable.ts +++ b/packages/altair-core/src/request/handlers/action-cable.ts @@ -38,7 +38,7 @@ export class ActionCableRequestHandler implements GraphQLRequestHandler { url: request.url, requestStartTimestamp, requestEndTimestamp, - resopnseTimeMs: requestEndTimestamp - requestStartTimestamp, + responseTimeMs: requestEndTimestamp - requestStartTimestamp, }); } diff --git a/packages/altair-core/src/request/handlers/http.spec.ts b/packages/altair-core/src/request/handlers/http.spec.ts index 7597520c98..883f924a20 100644 --- a/packages/altair-core/src/request/handlers/http.spec.ts +++ b/packages/altair-core/src/request/handlers/http.spec.ts @@ -81,7 +81,7 @@ describe('HTTP handler', () => { url: 'http://localhost:3000/graphql', requestStartTimestamp: expect.any(Number), requestEndTimestamp: expect.any(Number), - resopnseTimeMs: expect.any(Number), + responseTimeMs: expect.any(Number), }), ]); }); @@ -129,7 +129,7 @@ describe('HTTP handler', () => { url: 'http://localhost:3000/graphql?query=query+%7B+hello+%7D&variables=%7B%7D&operationName=hello', requestStartTimestamp: expect.any(Number), requestEndTimestamp: expect.any(Number), - resopnseTimeMs: expect.any(Number), + responseTimeMs: expect.any(Number), }), ]); }); @@ -193,7 +193,7 @@ describe('HTTP handler', () => { url: 'http://localhost:3000/graphql', requestStartTimestamp: expect.any(Number), requestEndTimestamp: expect.any(Number), - resopnseTimeMs: expect.any(Number), + responseTimeMs: expect.any(Number), }), ]); }); @@ -255,7 +255,7 @@ describe('HTTP handler', () => { url: 'http://localhost:3000/graphql', requestStartTimestamp: expect.any(Number), requestEndTimestamp: expect.any(Number), - resopnseTimeMs: expect.any(Number), + responseTimeMs: expect.any(Number), }), ]); }); @@ -290,7 +290,7 @@ describe('HTTP handler', () => { url: 'http://localhost:3000/graphql', requestStartTimestamp: expect.any(Number), requestEndTimestamp: expect.any(Number), - resopnseTimeMs: expect.any(Number), + responseTimeMs: expect.any(Number), }), ]); }); @@ -340,7 +340,7 @@ describe('HTTP handler', () => { url: 'http://localhost:3000/graphql?query=query+%7B+hello+%7D&variables=%7B%7D&operationName=hello', requestStartTimestamp: expect.any(Number), requestEndTimestamp: expect.any(Number), - resopnseTimeMs: expect.any(Number), + responseTimeMs: expect.any(Number), }), ]); }); @@ -459,7 +459,7 @@ describe('HTTP handler', () => { url: 'http://localhost:3000/simple-stream', requestStartTimestamp: expect.any(Number), requestEndTimestamp: expect.any(Number), - resopnseTimeMs: expect.any(Number), + responseTimeMs: expect.any(Number), }), expect.objectContaining({ ok: true, @@ -469,7 +469,7 @@ describe('HTTP handler', () => { url: 'http://localhost:3000/simple-stream', requestStartTimestamp: expect.any(Number), requestEndTimestamp: expect.any(Number), - resopnseTimeMs: expect.any(Number), + responseTimeMs: expect.any(Number), }), expect.objectContaining({ ok: true, @@ -479,7 +479,7 @@ describe('HTTP handler', () => { url: 'http://localhost:3000/simple-stream', requestStartTimestamp: expect.any(Number), requestEndTimestamp: expect.any(Number), - resopnseTimeMs: expect.any(Number), + responseTimeMs: expect.any(Number), }), ]); }); @@ -607,7 +607,7 @@ describe('HTTP handler', () => { url: 'http://localhost:3000/multipart-stream', requestStartTimestamp: expect.any(Number), requestEndTimestamp: expect.any(Number), - resopnseTimeMs: expect.any(Number), + responseTimeMs: expect.any(Number), }), expect.objectContaining({ ok: true, @@ -617,7 +617,7 @@ describe('HTTP handler', () => { url: 'http://localhost:3000/multipart-stream', requestStartTimestamp: expect.any(Number), requestEndTimestamp: expect.any(Number), - resopnseTimeMs: expect.any(Number), + responseTimeMs: expect.any(Number), }), expect.objectContaining({ ok: true, @@ -627,7 +627,7 @@ describe('HTTP handler', () => { url: 'http://localhost:3000/multipart-stream', requestStartTimestamp: expect.any(Number), requestEndTimestamp: expect.any(Number), - resopnseTimeMs: expect.any(Number), + responseTimeMs: expect.any(Number), }), expect.objectContaining({ ok: true, @@ -637,7 +637,7 @@ describe('HTTP handler', () => { url: 'http://localhost:3000/multipart-stream', requestStartTimestamp: expect.any(Number), requestEndTimestamp: expect.any(Number), - resopnseTimeMs: expect.any(Number), + responseTimeMs: expect.any(Number), }), expect.objectContaining({ ok: true, @@ -647,7 +647,7 @@ describe('HTTP handler', () => { url: 'http://localhost:3000/multipart-stream', requestStartTimestamp: expect.any(Number), requestEndTimestamp: expect.any(Number), - resopnseTimeMs: expect.any(Number), + responseTimeMs: expect.any(Number), }), ]); }); @@ -720,7 +720,7 @@ describe('HTTP handler', () => { url: 'http://localhost:3000/multipart-stream-2', requestStartTimestamp: expect.any(Number), requestEndTimestamp: expect.any(Number), - resopnseTimeMs: expect.any(Number), + responseTimeMs: expect.any(Number), }), expect.objectContaining({ ok: true, @@ -730,7 +730,7 @@ describe('HTTP handler', () => { url: 'http://localhost:3000/multipart-stream-2', requestStartTimestamp: expect.any(Number), requestEndTimestamp: expect.any(Number), - resopnseTimeMs: expect.any(Number), + responseTimeMs: expect.any(Number), }), ]); }); diff --git a/packages/altair-core/src/request/handlers/http.ts b/packages/altair-core/src/request/handlers/http.ts index 7b4fa6bc7f..b60b3de07d 100644 --- a/packages/altair-core/src/request/handlers/http.ts +++ b/packages/altair-core/src/request/handlers/http.ts @@ -147,7 +147,7 @@ export class HttpRequestHandler implements GraphQLRequestHandler { requestStartTimestamp: requestStartTime, requestEndTimestamp: requestEndTime, // this is redundant data - resopnseTimeMs: requestEndTime - requestStartTime, + responseTimeMs: requestEndTime - requestStartTime, }; // Send the data to the observer diff --git a/packages/altair-core/src/request/types.ts b/packages/altair-core/src/request/types.ts index fd88e76dda..9b2e780f8a 100644 --- a/packages/altair-core/src/request/types.ts +++ b/packages/altair-core/src/request/types.ts @@ -40,7 +40,7 @@ export interface GraphQLResponseData { /** * The time taken to get the response in milliseconds */ - resopnseTimeMs: number; + responseTimeMs: number; } export interface GraphQLRequestHandler { diff --git a/packages/altair-core/src/request/utils.ts b/packages/altair-core/src/request/utils.ts index 866a8a585c..cbf2a9f30f 100644 --- a/packages/altair-core/src/request/utils.ts +++ b/packages/altair-core/src/request/utils.ts @@ -19,7 +19,7 @@ export const simpleResponseObserver = ( url: url, requestStartTimestamp, requestEndTimestamp, - resopnseTimeMs: requestEndTimestamp - requestStartTimestamp, + responseTimeMs: requestEndTimestamp - requestStartTimestamp, }); }, error: (...args) => subscriber.error(...args), From 7027437ce49cd51849f470fc7a073a0412c01f93 Mon Sep 17 00:00:00 2001 From: VISHNU7KASIREDDY Date: Wed, 3 Dec 2025 19:24:17 +0530 Subject: [PATCH 2/2] fix: correct mock data responseTimeMs to match timestamp difference Changed responseTimeMs from 1.5 to 1 to match the difference between requestEndTimestamp (2) and requestStartTimestamp (1) in test mock data. --- .../modules/altair/services/gql/gql.service.spec.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/altair-app/src/app/modules/altair/services/gql/gql.service.spec.ts b/packages/altair-app/src/app/modules/altair/services/gql/gql.service.spec.ts index a8c58865a3..7e3d9a82e7 100644 --- a/packages/altair-app/src/app/modules/altair/services/gql/gql.service.spec.ts +++ b/packages/altair-app/src/app/modules/altair/services/gql/gql.service.spec.ts @@ -152,7 +152,7 @@ describe('GqlService', () => { url: 'http://test.com', requestStartTimestamp: 1, requestEndTimestamp: 2, - responseTimeMs: 1.5, + responseTimeMs: 1, }); } default: @@ -167,7 +167,7 @@ describe('GqlService', () => { url: 'http://test.com', requestStartTimestamp: 1, requestEndTimestamp: 2, - responseTimeMs: 1.5, + responseTimeMs: 1, }); } }; @@ -216,7 +216,7 @@ describe('GqlService', () => { url: 'http://test.com', requestStartTimestamp: 1, requestEndTimestamp: 2, - responseTimeMs: 1.5, + responseTimeMs: 1, }); } default: @@ -231,7 +231,7 @@ describe('GqlService', () => { url: 'http://test.com', requestStartTimestamp: 1, requestEndTimestamp: 2, - responseTimeMs: 1.5, + responseTimeMs: 1, }); } }); @@ -283,7 +283,7 @@ describe('GqlService', () => { url: 'http://test.com', requestStartTimestamp: 1, requestEndTimestamp: 2, - responseTimeMs: 1.5, + responseTimeMs: 1, }); } };