Skip to content

fix: correct typo in property name resopnseTimeMs → responseTimeMsfix: correct typo in property name resopnseTimeMs → responseTimeMs #2954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
imolorhe merged 3 commits into from
Dec 9, 2025
Merged

fix: correct typo in property name resopnseTimeMs → responseTimeMsfix: correct typo in property name resopnseTimeMs → responseTimeMs #2954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ecebe4
fix: correct typo in property name resopnseTimeMs → responseTimeMs
VISHNU7KASIREDDY Dec 3, 2025
7027437
fix: correct mock data responseTimeMs to match timestamp difference
VISHNU7KASIREDDY Dec 3, 2025
a9d55af
Merge branch 'master' into fix/typo-response-time-ms
imolorhe Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/altair-app/src/app/modules/altair/services/gql/gql.service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ describe('GqlService', () => {
url: 'http://test.com',
requestStartTimestamp: 1,
requestEndTimestamp: 2,
resopnseTimeMs: 1.5,
responseTimeMs: 1,
});
}
default:
Expand All @@ -167,7 +167,7 @@ describe('GqlService', () => {
url: 'http://test.com',
requestStartTimestamp: 1,
requestEndTimestamp: 2,
resopnseTimeMs: 1.5,
responseTimeMs: 1,
});
}
};
Expand Down Expand Up @@ -216,7 +216,7 @@ describe('GqlService', () => {
url: 'http://test.com',
requestStartTimestamp: 1,
requestEndTimestamp: 2,
resopnseTimeMs: 1.5,
responseTimeMs: 1,
});
}
default:
Expand All @@ -231,7 +231,7 @@ describe('GqlService', () => {
url: 'http://test.com',
requestStartTimestamp: 1,
requestEndTimestamp: 2,
resopnseTimeMs: 1.5,
responseTimeMs: 1,
});
}
});
Expand Down Expand Up @@ -283,7 +283,7 @@ describe('GqlService', () => {
url: 'http://test.com',
requestStartTimestamp: 1,
requestEndTimestamp: 2,
resopnseTimeMs: 1.5,
responseTimeMs: 1,
});
}
};
Expand Down
2 changes: 1 addition & 1 deletion packages/altair-app/src/app/modules/altair/services/gql/gql.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,7 +690,7 @@ export class GqlService {
url: response.url,
requestStartTime: response.requestStartTimestamp,
requestEndTime: response.requestEndTimestamp,
responseTime: response.resopnseTimeMs,
responseTime: response.responseTimeMs,
};
})
);
Expand Down
8 changes: 4 additions & 4 deletions packages/altair-core/src/request/adapters.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ describe('SubscriptionProviderRequestHandlerAdapter', () => {
ok: true,
requestEndTimestamp: expect.any(Number),
requestStartTimestamp: expect.any(Number),
resopnseTimeMs: expect.any(Number),
responseTimeMs: expect.any(Number),
status: 200,
statusText: 'OK',
url: 'http://localhost:3000/graphql',
Expand Down Expand Up @@ -100,7 +100,7 @@ describe('SubscriptionProviderRequestHandlerAdapter', () => {
ok: true,
requestEndTimestamp: expect.any(Number),
requestStartTimestamp: expect.any(Number),
resopnseTimeMs: expect.any(Number),
responseTimeMs: expect.any(Number),
status: 200,
statusText: 'OK',
url: 'http://localhost:3000/graphql',
Expand All @@ -111,7 +111,7 @@ describe('SubscriptionProviderRequestHandlerAdapter', () => {
ok: true,
requestEndTimestamp: expect.any(Number),
requestStartTimestamp: expect.any(Number),
resopnseTimeMs: expect.any(Number),
responseTimeMs: expect.any(Number),
status: 200,
statusText: 'OK',
url: 'http://localhost:3000/graphql',
Expand Down Expand Up @@ -158,7 +158,7 @@ describe('SubscriptionProviderRequestHandlerAdapter', () => {
ok: true,
requestEndTimestamp: expect.any(Number),
requestStartTimestamp: expect.any(Number),
resopnseTimeMs: expect.any(Number),
responseTimeMs: expect.any(Number),
status: 200,
statusText: 'OK',
url: 'http://localhost:3000/graphql',
Expand Down
2 changes: 1 addition & 1 deletion packages/altair-core/src/request/handlers/action-cable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export class ActionCableRequestHandler implements GraphQLRequestHandler {
url: request.url,
requestStartTimestamp,
requestEndTimestamp,
resopnseTimeMs: requestEndTimestamp - requestStartTimestamp,
responseTimeMs: requestEndTimestamp - requestStartTimestamp,
});
}

Expand Down
32 changes: 16 additions & 16 deletions packages/altair-core/src/request/handlers/http.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ describe('HTTP handler', () => {
url: 'http://localhost:3000/graphql',
requestStartTimestamp: expect.any(Number),
requestEndTimestamp: expect.any(Number),
resopnseTimeMs: expect.any(Number),
responseTimeMs: expect.any(Number),
}),
]);
});
Expand Down Expand Up @@ -129,7 +129,7 @@ describe('HTTP handler', () => {
url: 'http://localhost:3000/graphql?query=query+%7B+hello+%7D&variables=%7B%7D&operationName=hello',
requestStartTimestamp: expect.any(Number),
requestEndTimestamp: expect.any(Number),
resopnseTimeMs: expect.any(Number),
responseTimeMs: expect.any(Number),
}),
]);
});
Expand Down Expand Up @@ -193,7 +193,7 @@ describe('HTTP handler', () => {
url: 'http://localhost:3000/graphql',
requestStartTimestamp: expect.any(Number),
requestEndTimestamp: expect.any(Number),
resopnseTimeMs: expect.any(Number),
responseTimeMs: expect.any(Number),
}),
]);
});
Expand Down Expand Up @@ -255,7 +255,7 @@ describe('HTTP handler', () => {
url: 'http://localhost:3000/graphql',
requestStartTimestamp: expect.any(Number),
requestEndTimestamp: expect.any(Number),
resopnseTimeMs: expect.any(Number),
responseTimeMs: expect.any(Number),
}),
]);
});
Expand Down Expand Up @@ -290,7 +290,7 @@ describe('HTTP handler', () => {
url: 'http://localhost:3000/graphql',
requestStartTimestamp: expect.any(Number),
requestEndTimestamp: expect.any(Number),
resopnseTimeMs: expect.any(Number),
responseTimeMs: expect.any(Number),
}),
]);
});
Expand Down Expand Up @@ -340,7 +340,7 @@ describe('HTTP handler', () => {
url: 'http://localhost:3000/graphql?query=query+%7B+hello+%7D&variables=%7B%7D&operationName=hello',
requestStartTimestamp: expect.any(Number),
requestEndTimestamp: expect.any(Number),
resopnseTimeMs: expect.any(Number),
responseTimeMs: expect.any(Number),
}),
]);
});
Expand Down Expand Up @@ -459,7 +459,7 @@ describe('HTTP handler', () => {
url: 'http://localhost:3000/simple-stream',
requestStartTimestamp: expect.any(Number),
requestEndTimestamp: expect.any(Number),
resopnseTimeMs: expect.any(Number),
responseTimeMs: expect.any(Number),
}),
expect.objectContaining({
ok: true,
Expand All @@ -469,7 +469,7 @@ describe('HTTP handler', () => {
url: 'http://localhost:3000/simple-stream',
requestStartTimestamp: expect.any(Number),
requestEndTimestamp: expect.any(Number),
resopnseTimeMs: expect.any(Number),
responseTimeMs: expect.any(Number),
}),
expect.objectContaining({
ok: true,
Expand All @@ -479,7 +479,7 @@ describe('HTTP handler', () => {
url: 'http://localhost:3000/simple-stream',
requestStartTimestamp: expect.any(Number),
requestEndTimestamp: expect.any(Number),
resopnseTimeMs: expect.any(Number),
responseTimeMs: expect.any(Number),
}),
]);
});
Expand Down Expand Up @@ -607,7 +607,7 @@ describe('HTTP handler', () => {
url: 'http://localhost:3000/multipart-stream',
requestStartTimestamp: expect.any(Number),
requestEndTimestamp: expect.any(Number),
resopnseTimeMs: expect.any(Number),
responseTimeMs: expect.any(Number),
}),
expect.objectContaining({
ok: true,
Expand All @@ -617,7 +617,7 @@ describe('HTTP handler', () => {
url: 'http://localhost:3000/multipart-stream',
requestStartTimestamp: expect.any(Number),
requestEndTimestamp: expect.any(Number),
resopnseTimeMs: expect.any(Number),
responseTimeMs: expect.any(Number),
}),
expect.objectContaining({
ok: true,
Expand All @@ -627,7 +627,7 @@ describe('HTTP handler', () => {
url: 'http://localhost:3000/multipart-stream',
requestStartTimestamp: expect.any(Number),
requestEndTimestamp: expect.any(Number),
resopnseTimeMs: expect.any(Number),
responseTimeMs: expect.any(Number),
}),
expect.objectContaining({
ok: true,
Expand All @@ -637,7 +637,7 @@ describe('HTTP handler', () => {
url: 'http://localhost:3000/multipart-stream',
requestStartTimestamp: expect.any(Number),
requestEndTimestamp: expect.any(Number),
resopnseTimeMs: expect.any(Number),
responseTimeMs: expect.any(Number),
}),
expect.objectContaining({
ok: true,
Expand All @@ -647,7 +647,7 @@ describe('HTTP handler', () => {
url: 'http://localhost:3000/multipart-stream',
requestStartTimestamp: expect.any(Number),
requestEndTimestamp: expect.any(Number),
resopnseTimeMs: expect.any(Number),
responseTimeMs: expect.any(Number),
}),
]);
});
Expand Down Expand Up @@ -720,7 +720,7 @@ describe('HTTP handler', () => {
url: 'http://localhost:3000/multipart-stream-2',
requestStartTimestamp: expect.any(Number),
requestEndTimestamp: expect.any(Number),
resopnseTimeMs: expect.any(Number),
responseTimeMs: expect.any(Number),
}),
expect.objectContaining({
ok: true,
Expand All @@ -730,7 +730,7 @@ describe('HTTP handler', () => {
url: 'http://localhost:3000/multipart-stream-2',
requestStartTimestamp: expect.any(Number),
requestEndTimestamp: expect.any(Number),
resopnseTimeMs: expect.any(Number),
responseTimeMs: expect.any(Number),
}),
]);
});
Expand Down
2 changes: 1 addition & 1 deletion packages/altair-core/src/request/handlers/http.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ export class HttpRequestHandler implements GraphQLRequestHandler {
requestStartTimestamp: requestStartTime,
requestEndTimestamp: requestEndTime,
// this is redundant data
resopnseTimeMs: requestEndTime - requestStartTime,
responseTimeMs: requestEndTime - requestStartTime,
};

// Send the data to the observer
Expand Down
2 changes: 1 addition & 1 deletion packages/altair-core/src/request/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export interface GraphQLResponseData {
/**
* The time taken to get the response in milliseconds
*/
resopnseTimeMs: number;
responseTimeMs: number;
}

export interface GraphQLRequestHandler {
Expand Down
2 changes: 1 addition & 1 deletion packages/altair-core/src/request/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export const simpleResponseObserver = (
url: url,
requestStartTimestamp,
requestEndTimestamp,
resopnseTimeMs: requestEndTimestamp - requestStartTimestamp,
responseTimeMs: requestEndTimestamp - requestStartTimestamp,
});
},
error: (...args) => subscriber.error(...args),
Expand Down
Loading