Sorry to bother you (not an issue)

[trip5]

Regarding the ESP32Radio-V2 project... (I can't leave a message for you on your fork of it)

Actually I think Edzel is a bit protective of his code... Every single update is by him. He has never accepted a PR - although to be fair, there haven't been many requests nor have any of them been actually useful.

And the more I look at his code, I realize it's highly readable (good!)... and ancient. He originally made it for ESP8266 and hasn't really kept up with the code. There are very old sections in it that seem unfunctional and hard to bring up-to-date (like the OTA section which has probably been nonfunctional for many years). I really also wanted to modernize the SD Card section to use SdFat library but it doesn't feel right to fork it in this way, like I'd be stealing his code while trying to improve it...

So, anyways, I took a look around, thinking there might be other options out there. And there is: https://github.com/e2002/yoradio

It supports more displays and is routinely updated -- although it takes breaks for sure, who doesn't?

And it looks like they're working on a "screensaver" update, though it doesn't function on my OLED just yet. Looking at the code -- which by the way is dense and efficient, I guess it'll have a randomly located clock? That's pretty cool... still looking at it and analyzing the code to see where I can help out. It also lacks the one-button controls that Edzel's radio has... but I think that might be easy to add.
The menu system looks great and you can choose between multiple buttons and rotaries... and a touch screen! Seriously, it's a pretty good radio. On the negative, you are stuck using the ESP32 (or S3)'s default pins for SPI buses but that's not such a bad thing.

They've even used modern code for the VS1053 with the "patch" which allows it to play high-quality MP3s and FLAC files. And it seems compatible with more than the "green" VS1053B. And the PCM works well too!

You can leave this "issue" open as a communication with me if you like. I figured this repo of yours, it will go unnoticed except for you.

Sorry to bother you. Just got excited about it... BTW the "vaccum tube" clock looks great. I'm a clock addict so if I can afford another project, I might get one too! Haha.

[aly-fly]

hey, head the linked yoradio also seems that author does not accept PRs directly.
And it's based on Arduino, not on Platformio which is a step back..
I will keep an eye on that one; maybe I will migrate to that one in future. Currently I have two Ed's radios with my modifications and they are stable. I only use MQTT so rotary encoders are not a must for me.

The clock project is a fun one. When I bought my original version, it was 100+€, now you can get a knock-off version for 50€ or even less. And we do accept PRs :)

[trip5]

I'm pretty impressed with yoradio so far... and you may be right that they don't accept PRs directly, although to be fair, my first PR had #define for things that are more useful as WebUI options, something I'm not used to.

It may have started with Arduino but it works perfectly well in platformio. The .ino files are just legacy components that are being phased out... and you have to add some pointers to the platformio.ini file to get it 100% but I promise it works. That's all I use.

It's completely useable with one rotary or as little as 3 momentary switches. Long press and double-click functions can be used when not using a rotary or the full 5 buttons. But you prefer MQTT? They've got that too.

And straight up the best part? Starts playing within a few seconds of powering on. I think Edzel's code has a lot of checks in it. This one doesn't... although it does make setting up pins hit or miss and not enough logs to help you out.

If I have to maintain a fork of yoradio with my own additions, I completely will.

[aly-fly]

The startup time is PITA on the Ed's radio, that's true. Mostly caused by Config load and listing of available WiFi networks. This can be overridden to boot faster, but still takes quite a bit.
For now I was able to modify Ed's radio to fit my needs, in the future will test also Yoradio.
Getting a fork or a full repo where PRs are accepted would be a total win.