Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Downloading Features #8

Open
thethiny opened this issue Nov 27, 2021 · 5 comments
Open

File Downloading Features #8

thethiny opened this issue Nov 27, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@thethiny
Copy link

Hi,
It would be cool if you implement the following:

  • Deletion of the downloaded zip files
  • Verifying that a Yuzu Compatible mod is present (checking for .IPS or .pchtxt)
  • Logging the number of mods per game (not only number of games)
  • Not downloading mods that are already available (I think this would be impossible to detect if a mod updates)
  • Choosing what mods to download (checkbox menu or something)
    If you "don't have time" for it or aren't interested in this, let me know please so that I fork your repo and start working on them.
@amakvana
Copy link
Owner

Thanks! I'll add these into the TODO list 👍🏾 feel free to fork regardless, I don't mind

2nd bullet point - I assume this means checking if the version of the mod is supported with the version of the game currently dumped prior to downloading?

4th bullet point - could be tricky as the github page doesn't keep track of when the mod was last updated

@thethiny
Copy link
Author

thethiny commented Nov 28, 2021

I've never touched C# before but looks like this is gonna be the first for me. Will start on the 🍴 tomorrow.
For 2nd bullet point, I just mean to check the extension, as checking the file contents defeats the purpose.
For 4th bullet point you're right that's why I added (might be impossible).

@amakvana
Copy link
Owner

amakvana commented Nov 28, 2021

I've never touched C# before but looks like this is gonna be the first for me. Will start on the 🍴 tomorrow.

Nice!! If you need some help with things, feel free to ask!

I'll hopefully be getting some time off in the week and can implement these things

@thethiny
Copy link
Author

Cool! If I hadn't issued a PR by then then that means I failed 😂

@thethiny thethiny mentioned this issue Nov 29, 2021
@thethiny
Copy link
Author

I succeeded 😎

@amakvana amakvana added the enhancement New feature or request label Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants