Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: allow for composite Transition types and encode counters, etc, in transitions #27

Open
amandasystems opened this issue May 5, 2022 · 0 comments
Open

Refactor: allow for composite Transition types and encode counters, etc, in transitions #27

amandasystems opened this issue May 5, 2022 · 0 comments
Milestone
Cookie Points

Comments

@amandasystems
Copy link
Owner

This should greatly simplify the code.
@amandasystems amandasystems added this to the Cookie Points milestone May 5, 2022
amandasystems added a commit that referenced this issue May 20, 2022
@amandasystems
Verma: products are now materialised from smallest to largest
f1b118a 
This monster of a commit implements the long-overdue refactoring of #27 while attempting to fix a bug introduced by #24, replacing most support structures with inlined attributes in the edges of the automata. This enormously simplifies most of the implementation.

After this commit, the only retained support structure is the one holding the solver variables associated with each transition. I debate myself whether to fold them into the transition types in the same fashion.

Closes: #24, #27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Cookie Points
Development

No branches or pull requests
1 participant
@amandasystems