Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example not working correctly (any more) #564

Open
StefanoOcchetti opened this issue Sep 1, 2022 · 5 comments
Open

Example not working correctly (any more) #564

StefanoOcchetti opened this issue Sep 1, 2022 · 5 comments

Comments

@StefanoOcchetti
Copy link

The example is not running correctly any more.

  1. package.json
"example": "yarn build && cd example && webpack-dev-server",

should become:

"example": "yarn build && cd example && webpack serve",
  1. App.js

Controls are not shown. The following import is missing:

import 'mapbox-gl/dist/mapbox-gl.css';
@amaury1093
Copy link
Owner

@StefanoOcchetti Thanks! Would you like to create a PR?

@StefanoOcchetti
Copy link
Author

I'd love to... but I don't manage to push to a new branch... can you grant me new branch creation?

@amaury1093
Copy link
Owner

You need to first fork the project, then push your branches to your fork (you have rights there), and the create a Pull Request from your fork to this repo.

@StefanoOcchetti
Copy link
Author

yes, ok. I'll do that!

@StefanoOcchetti
Copy link
Author

#565

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants