Skip to content
This repository has been archived by the owner on Aug 31, 2021. It is now read-only.

sam publish duplicate semantic version issue #33

Open
sriram-mv opened this issue Feb 10, 2020 · 1 comment
Open

sam publish duplicate semantic version issue #33

sriram-mv opened this issue Feb 10, 2020 · 1 comment

Comments

@sriram-mv
Copy link

Description

When using sam publish command to publish a new version of a SAR app, if I forget to update the semantic version in the template metadata, it succeeds leading the user to think they published a new version.

Steps to reproduce

We use this script when publishing to SAR:
https://github.com/awslabs/aws-athena-query-federation/blob/master/tools/publish.sh

It has the exact commands that get run. The steps to reproduce are:

  1. use the script to publish an initial semantic version to SAR
  2. deploy an instance of that app
  3. make a code change to the app but forget to change the semantic version
  4. publish the code change using the script
  5. attempt to deply an update to the previous app instance.

You'll find that step #4 doesn't throw and error but that after step 5 which also won't error, the deployed app will still be running the code from step 1.

Expected result

Step #4 should somehow throw an error or helpful information to indicate a new version is not published so that we can stop before running step 5.

@sriram-mv
Copy link
Author

Copied from aws/aws-sam-cli#1764

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant