Serverless v4 compatibility

[ashley-jisc]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Bug Report

Error Description
When attempting to install this plugin with Serverless V4 (4.1.21) I get the following error

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving:[REDACTED]@1.0.0
npm ERR! Found: serverless@4.1.21
npm ERR! node_modules/serverless
npm ERR!   dev serverless@"4.1.21" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer serverless@"^2.60 || ^3.0.0" from serverless-domain-manager@7.3.8
npm ERR! node_modules/serverless-domain-manager
npm ERR!   dev serverless-domain-manager@"*" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! 
npm ERR! For a full report see:
npm ERR! /Users/work/.npm/_logs/2024-08-13T12_56_27_785Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in: /Users/work/.npm/_logs/2024-08-13T12_56_27_785Z-debug-0.log

Command Run
npm install serverless-domain-manager --save-dev

Domain Manager Configuration
Replace this with your own serverless.yml file (anonymized, of course) to help us better resolve your issue.
N/A

Versions

• Domain Manager version(s): 7.3.8 I assume
• Node/npm version: 20.11.1
• Serverless Version: 4.1.21
• Lambda Code: Node

Possible Solution
Update dependencies

Additional context/Screenshots
Add any other context about the problem here. If applicable, add screenshots to help explain.

[iNick]

It looks like the peerDependencies section in packages.json at npm is still:

"peerDependencies": {
    "serverless": "^2.60 || ^3.0.0"
  }

This should be fixed by this commit: 8dbb433
Hopefully this will be released with 7.4.0: #635

[franrivero]

We have the same issue when we try to use sls version 4 with domain manager, do you have any fix of this?

[rddimon]

Hi there
It should be fixed in the 7.4.0

Let us know in case any issues

[PhilThurston]

@rddimon we are still getting a similar error. The serverless.yml file has worked for years and stopped working with v4 being released.

phillip@ws:~/git/project$ npm list -g serverless-domain-manager serverless
/home/phillip/.nvm/versions/node/v20.16.0/lib
├─┬ serverless-domain-manager@7.4.0
│ └── serverless@4.3.3 deduped
└── serverless@4.3.3

✖ Serverless plugin "serverless-domain-manager" not found. Make sure it's installed and listed in the "plugins" section of your serverless config file. Use the --debug flag to learn more.
ServerlessError2: Serverless plugin "serverless-domain-manager" not found. Make sure it's installed and listed in the "plugins" section of your serverless config file. Use the --debug flag to learn more.
    at PluginManager.resolveServicePlugins (/home/phillip/.serverless/releases/4.3.3/serverless/lib/classes/plugin-manager.js:350:15)
    at PluginManager.loadAllPlugins (/home/phillip/.serverless/releases/4.3.3/serverless/lib/classes/plugin-manager.js:267:7)
    at Serverless.init (/home/phillip/.serverless/releases/4.3.3/serverless/lib/serverless.js:165:5)
    at runFramework (/home/phillip/.serverless/releases/4.3.3/sf-core/src/lib/runners/framework.js:191:5)
    at route (/home/phillip/.serverless/releases/4.3.3/sf-core/src/lib/router.js:221:10)
    at Object.run2 (/home/phillip/.serverless/releases/4.3.3/sf-core/src/index.js:45:3)
    at run3 (/home/phillip/.serverless/releases/4.3.3/sf-core/bin/sf-core.js:33:3)