remove wxCHECK_VERSION no longer necessary

and more useless code, because now wxWidgets 3.2 is required

Author: sc0w

src/CFile.cpp

@@ -87,10 +87,6 @@ char* mktemp( char * path ) { return path ;}
 #	define   O_BINARY    (0)
 #endif  //__UNIX__
 
-#if defined(__WINDOWS__) && !wxCHECK_VERSION(3, 1, 0)
-#include <wx/msw/mslu.h>
-#endif
-
 
 // The following defines handle different names across platforms,
 // and ensures that we use 64b IO on windows (only 32b by default).

src/ExternalConnector.cpp

@@ -665,31 +665,6 @@ wxString CaMuleExternalConnector::SetLocale(const wxString& language)
 	return m_locale == NULL ? wxString() : m_locale->GetCanonicalName();
 }
 
-#if !wxUSE_GUI && defined(__WXMAC__) && !wxCHECK_VERSION(2, 9, 0)
-
-#include <wx/apptrait.h> // Do_not_auto_remove
-#include <wx/stdpaths.h> // Do_not_auto_remove
-
-class CaMuleExternalConnectorTraits : public wxConsoleAppTraits
-{
-public:
-	virtual wxStandardPathsBase& GetStandardPaths()
-	{
-		return s_stdPaths;
-	}
-
-private:
-	static wxStandardPathsCF s_stdPaths;
-};
-
-wxStandardPathsCF CaMuleExternalConnectorTraits::s_stdPaths;
-
-wxAppTraits* CaMuleExternalConnector::CreateTraits()
-{
-	return new CaMuleExternalConnectorTraits;
-}
-
-#endif
 
 #if wxUSE_ON_FATAL_EXCEPTION
 // Gracefully handle fatal exceptions and print backtrace if possible

src/ExternalConnector.h

@@ -179,9 +179,6 @@ class CaMuleExternalConnector : public wxApp
 	CCommandTree	m_commands;
 	const char *	m_appname;
 
-#if !wxUSE_GUI && defined(__WXMAC__) && !wxCHECK_VERSION(2, 9, 0)
-	virtual wxAppTraits* CreateTraits();
-#endif
 
 private:
 	wxString	m_configFileName;

src/Logger.cpp

@@ -307,7 +307,6 @@ CLoggerTarget::CLoggerTarget()
 {
 }
 
-#if wxCHECK_VERSION(2, 9, 0)
 void CLoggerTarget::DoLogText(const wxString &msg)
 {
 	// prevent infinite recursion
@@ -326,31 +325,6 @@ void CLoggerTarget::DoLogText(const wxString &msg)
 
 	recursion = false;
 }
-#else
-void CLoggerTarget::DoLogString(const wxChar* msg, time_t)
-{
-	// prevent infinite recursion
-	static bool recursion = false;
-	if (recursion) {
-		return;
-	}
-	recursion = true;
-
-	wxCHECK_RET(msg, wxT("Log message is NULL in DoLogString!"));
-
-	wxString str(msg);
-
-	// This is much simpler than manually handling all wx log-types.
-	// cppcheck-suppress duplicateBranch
-	if (str.StartsWith(_("ERROR: ")) || str.StartsWith(_("WARNING: "))) {
-		AddLogLineC(str);
-	} else {
-		AddLogLineN(str);
-	}
-
-	recursion = false;
-}
-#endif
 
 CLoggerAccess::CLoggerAccess()
 {

src/Logger.h

@@ -320,13 +320,9 @@ class CLoggerTarget : public wxLog
 	CLoggerTarget();
 
 	/**
-	 * @see wxLog::DoLogString
+	 * @see wxLog::DoLogText
 	 */
-#if wxCHECK_VERSION(2, 9, 0)
 	void DoLogText(const wxString &msg);
-#else
-	void DoLogString(const wxChar *msg, time_t);
-#endif
 };
 
 

src/MuleGifCtrl.cpp

@@ -116,11 +116,7 @@ void MuleGifCtrl::Start()
 	if (m_decoder && m_decoder->IsAnimation()) {
 		m_timer.Stop();
 		m_decoder->GoLastFrame();
-#if wxCHECK_VERSION(2, 9, 0)
 		wxTimerEvent evt(m_timer);
-#else
-		wxTimerEvent evt;
-#endif
 		OnTimer(evt);
 	}
 }

src/OtherFunctions.cpp

@@ -1090,10 +1090,6 @@ wxString GetConfigDir(const wxString &configFileBase)
 void InitCustomLanguages()
 {
 	wxLanguageInfo info;
-
-#if !wxCHECK_VERSION(2, 9, 0)
-	CUSTOMLANGUAGE(wxLANGUAGE_ASTURIAN,	"ast",	0,	0,	wxLayout_LeftToRight,	"Asturian");
-#endif
 }
 
 
@@ -1103,12 +1099,6 @@ void InitLocale(wxLocale& locale, int language)
 
 #if defined(__WXMAC__) || defined(__WINDOWS__)
 	locale.AddCatalogLookupPathPrefix(JoinPaths(wxStandardPaths::Get().GetDataDir(), wxT("locale")));
-#else
-#if (wxCHECK_VERSION(2,9,5) && !wxCHECK_VERSION(3,0,3)) || (wxCHECK_VERSION(3,1,0) && !wxCHECK_VERSION(3,1,1))
-	// Add correct place to look for catalog files if we're using a wxWidgets version where it's broken
-	// See also http://trac.wxwidgets.org/ticket/17740
-	locale.AddCatalogLookupPathPrefix(JoinPaths(JoinPaths(wxStandardPaths::Get().GetInstallPrefix(), wxT("share")), wxT("locale")));
-#endif /* wxCHECK_VERSION(2,9,5)... */
 #endif /* (!)(defined(__WXMAC__) || defined(__WINDOWS__)) */
 
 	locale.AddCatalog(wxT(PACKAGE));

src/OtherFunctions.h

@@ -338,11 +338,6 @@ inline long int make_full_ed2k_version(int a, int b, int c) {
 
 wxString GetConfigDir(const wxString &configFile);
 
-#if !wxCHECK_VERSION(2, 9, 0)
-enum {
-	wxLANGUAGE_ASTURIAN	= wxLANGUAGE_USER_DEFINED + 1
-};
-#endif
 
 /**
  * Adds aMule's custom languages to db.

src/PartFile.cpp

@@ -36,11 +36,10 @@
 
 #include <wx/utils.h>
 #include <wx/tokenzr.h>		// Needed for wxStringTokenizer
-#if wxCHECK_VERSION(2,9,0)
+
 #ifndef AMULE_DAEMON
 #include <wx/notifmsg.h>	// Needed for wxNotificationMessage
 #endif
-#endif
 
 #include "KnownFileList.h"	// Needed for CKnownFileList
 #include "CanceledFileList.h"
@@ -2164,7 +2163,6 @@ void CPartFile::CompleteFileEnded(bool errorOccured, const CPath& newname)
 		m_CorruptionBlackBox->Free();
 
 		AddLogLineC(CFormat( _("Finished downloading: %s") ) % GetFileName() );
-#if wxCHECK_VERSION(2,9,0)
 #ifndef AMULE_DAEMON
 		if (thePrefs::ShowNotifications()) {
 			wxNotificationMessage *notification = new wxNotificationMessage ();
@@ -2174,7 +2172,6 @@ void CPartFile::CompleteFileEnded(bool errorOccured, const CPath& newname)
 			notification->Show(7);
 			delete notification;
 		}
-#endif
 #endif
 	}
 

src/PrefsUnifiedDlg.cpp

@@ -511,11 +511,6 @@ bool PrefsUnifiedDlg::TransferToWindow()
 	FindWindow(IDC_WEBUPNPTCPPORTTEXT)->Enable(thePrefs::GetUPnPWebServerEnabled());
 #endif
 
-#if !wxCHECK_VERSION(2,9,0)
-	CastChild(IDC_NOTIF, wxCheckBox)->SetValue(false);
-	FindWindow(IDC_NOTIF)->Enable(false);
-#endif
-
 #ifdef __DEBUG__
 	// Set debugging toggles
 	int count = theLogger.GetDebugCategoryCount();

src/amule.cpp

@@ -90,11 +90,7 @@
 #ifndef AMULE_DAEMON
 	#ifdef __WXMAC__
 		#include <CoreFoundation/CFBundle.h>  // Do_not_auto_remove
-		#if wxCHECK_VERSION(2, 9, 0)
-			#include <wx/osx/core/cfstring.h>  // Do_not_auto_remove
-		#else
-			#include <wx/mac/corefoundation/cfstring.h>  // Do_not_auto_remove
-		#endif
+		#include <wx/osx/core/cfstring.h>  // Do_not_auto_remove
 	#endif
 	#include <wx/msgdlg.h>
 
@@ -628,11 +624,7 @@ bool CamuleApp::OnInit()
 			if (absoluteUrl) {
 				CFStringRef amulewebCfstr = CFURLCopyFileSystemPath(absoluteUrl, kCFURLPOSIXPathStyle);
 				CFRelease(absoluteUrl);
-	#if wxCHECK_VERSION(2, 9, 0)
 				amulewebPath = wxCFStringRef(amulewebCfstr).AsString(wxLocale::GetSystemEncoding());
-	#else
-				amulewebPath = wxMacCFStringHolder(amulewebCfstr).AsString(wxLocale::GetSystemEncoding());
-	#endif
 			}
 		}
 #endif

src/amule.h

@@ -431,116 +431,10 @@ extern CamuleGuiApp *theApp;
 
 #else /* ! AMULE_DAEMON */
 
-// wxWidgets 2.8 requires special code for event handling and sockets.
-// 2.9 doesn't, so standard event loop and sockets can be used
-//
-// Windows: aMuled compiles with 2.8 (without the special code),
-// but works only with 2.9
-
-#if !wxCHECK_VERSION(2, 9, 0)
-	// wx 2.8 needs a hand-made event loop in any case
-	#define AMULED28_EVENTLOOP
-
-	#ifndef ASIO_SOCKETS
-		// MSW: can't run amuled with 2.8 without ASIO sockets, just get it compiled
-		#ifndef __WINDOWS__
-			#define AMULED28_SOCKETS
-		#endif
-	#endif
-#endif
-
-#ifdef AMULED28_SOCKETS
-#include <wx/socket.h>
-
-class CSocketSet;
-
-
-class CAmuledGSocketFuncTable : public GSocketGUIFunctionsTable
-{
-private:
-	CSocketSet *m_in_set, *m_out_set;
-
-	wxMutex m_lock;
-public:
-	CAmuledGSocketFuncTable();
-
-	void AddSocket(GSocket *socket, GSocketEvent event);
-	void RemoveSocket(GSocket *socket, GSocketEvent event);
-	void RunSelect();
-
-	virtual bool OnInit();
-	virtual void OnExit();
-	virtual bool CanUseEventLoop();
-	virtual bool Init_Socket(GSocket *socket);
-	virtual void Destroy_Socket(GSocket *socket);
-	virtual void Install_Callback(GSocket *socket, GSocketEvent event);
-	virtual void Uninstall_Callback(GSocket *socket, GSocketEvent event);
-	virtual void Enable_Events(GSocket *socket);
-	virtual void Disable_Events(GSocket *socket);
-};
-
-
-#endif // AMULED28_SOCKETS
-
-// AppTrait functionality is required for 2.8 wx sockets
-// Otherwise it's used to prevent zombie child processes,
-// which stops working with wx 2.9.5.
-// So disable it there (no idea if this has a noticeable impact).
-
-#if !wxCHECK_VERSION(2, 9, 5) && !defined(__WINDOWS__)
-#define AMULED_APPTRAITS
-#endif
-
-#ifdef AMULED_APPTRAITS
-
-typedef std::map<int, class wxEndProcessData *> EndProcessDataMap;
-
-#include <wx/apptrait.h>
-
-class CDaemonAppTraits : public wxConsoleAppTraits
-{
-private:
-	struct sigaction m_oldSignalChildAction;
-	struct sigaction m_newSignalChildAction;
-
-#ifdef AMULED28_SOCKETS
-	CAmuledGSocketFuncTable *m_table;
-	wxMutex m_lock;
-	std::list<wxObject *> m_sched_delete;
-public:
-	CDaemonAppTraits(CAmuledGSocketFuncTable *table);
-	virtual GSocketGUIFunctionsTable* GetSocketGUIFunctionsTable();
-	virtual void ScheduleForDestroy(wxObject *object);
-	virtual void RemoveFromPendingDelete(wxObject *object);
-
-	void DeletePending();
-#else	// AMULED28_SOCKETS
-public:
-	CDaemonAppTraits();
-#endif	// !AMULED28_SOCKETS
-
-	virtual int WaitForChild(wxExecuteData& execData);
-
-#if defined(__WXMAC__) && !wxCHECK_VERSION(2, 9, 0)
-	virtual wxStandardPathsBase& GetStandardPaths();
-#endif
-};
-
-void OnSignalChildHandler(int signal, siginfo_t *siginfo, void *ucontext);
-pid_t AmuleWaitPid(pid_t pid, int *status, int options, wxString *msg);
-
-#endif // AMULED_APPTRAITS
-
 
 class CamuleDaemonApp : public CamuleApp
 {
 private:
-#ifdef AMULED28_EVENTLOOP
-	bool m_Exit;
-#endif
-#ifdef AMULED28_SOCKETS
-	CAmuledGSocketFuncTable *m_table;
-#endif
 	bool OnInit();
 	int OnRun();
 	int OnExit();
@@ -554,20 +448,7 @@ class CamuleDaemonApp : public CamuleApp
 	// This function are overridden to perform this.
 	virtual bool Initialize(int& argc_, wxChar **argv_);
 
-#ifdef AMULED_APPTRAITS
-	struct sigaction m_oldSignalChildAction;
-	struct sigaction m_newSignalChildAction;
 public:
-	wxAppTraits *CreateTraits();
-#endif // AMULED_APPTRAITS
-
-public:
-
-#ifdef AMULED28_EVENTLOOP
-	CamuleDaemonApp();
-
-	void ExitMainLoop() { m_Exit = true; }
-#endif
 
 	bool CopyTextToClipboard(wxString strText);